seanpeters86 / bfa-shadow-priest Goto Github PK
View Code? Open in Web Editor NEWSim Repository for Shadow Priests in BfA
Home Page: https://warcraftpriests.com/
Sim Repository for Shadow Priests in BfA
Home Page: https://warcraftpriests.com/
Created base sheet with simple weights from memory of the fights:
https://docs.google.com/spreadsheets/d/1pQBVcveJ_vN2_vj-KUFBZ1zBwsheldrmUmj5KmBSiw8/edit?usp=sharing
Analysis.py should also export a csv of the data for easier exporting for more analysis
CodeFactor found an issue: Duplicate Code
It's currently on:
stats\profiles.py:67-76
sim.py:35-44
Commit 3760a69
Is your feature request related to a problem? Please describe.
When you have the Whispers of the Damned trait, you can use DA to keep the buff stacked at 6 for a longer period.
Describe the solution you'd like
If DA is talented and you have at least 1 rank of Whispers of the Damned, you should hold DA until after your first voidform to maintain stacks for as long as possible.
Without the new APL:
Whispers_of_the_Damned_1: 0.92%
With the new APL:
Whispers_of_the_Damned_1: 3.76%
Is your feature request related to a problem? Please describe.
Analyze.py and Analyze.rs should be combined into a single file
Is your feature request related to a problem? Please describe.
It's frustrating having to scroll down a ton to see the single target chart. Having them stacked side by side would be easier to view.
Describe the solution you'd like
A way to see both charts side by side for easier analysis.
For some reason, ansh wants stat weights for every talent combo. Cuz he's ansh.
Dark ascension is bugged and is currently doing 20% too much damage.
https://cdn.discordapp.com/attachments/234014456584077313/459455077330190336/image.png
Kaesebrezen - Today at 3:31 PM
the damage thing is because the shadowpriest aura hasn't dark ascension listed on it
because ingame it's treated fully as a void eruption cast
da_mul 1.088 vs da_mul 1.36
1st commit: simulationcraft/simc@c0ece41
After the raid releases iterate over the existing weights that were created in the original issue:
#40
With the amount of damage Void Eruption does, on X targets or X duration is it ever better to just wait
in voidform to be able to Void Eruption again?
i.e.
// Racials
if ( race == RACE_BLOOD_ELF )
default_list->add_action( "arcane_torrent,if=buff.voidform.down" );
Need to add a new section to sim that compares all available trinkets at various ilvls.
https://bfa.wowhead.com/trinkets/class:5/role:2?filter=166;8;0#50-2
Is your feature request related to a problem? Please describe.
I would like to embed the various data tables on external websites.
Dependent on #1
Need charts for this page: https://warcraftpriests.com/?p=1554&preview=true
The current things are not yet implemented/not working
Also have these: https://github.com/Juliacare/RaidSimming
Shot tested in-game vs. SimC timings of void bolt and noticed a pretty large difference.
The times in the chart are the seconds between each void bolt. Either there is a problem with mind flay not respecting the interrupt=1
in the APL, or Void Bolt isn't scaling properly with haste.
The problem doesn't really exist at all in the legion version of SimC, there's a chance our haste levels in legion just masked this problem, or something else changed between legion and bfa dev of SimC to break this.
Is your feature request related to a problem? Please describe.
Reduce duplicate code by combining profiles.py into a single file across all folders
Describe the solution you'd like
A single profiles.py file in the root of the repo that works with analyze.py and sim.py. Ideally this is called with an argument, so you can have python profiles.py talents/
Is your feature request related to a problem? Please describe.
Current google sheet charts are great as they pull from the repo, however the look cannot be customized as much.
Describe the solution you'd like
I've already built a script that will convert sim data to JSON data that should be easily read by a JS script for highcharts
Additional context
Rough Functions Required:
Seems like there are some sets/gear that should get simmed
When trying to use shadow crash in precombat you get this message:
Player DA_Mindbender_Wait attempted to add harmful action shadow_crash to precombat action list. Only spells with travel time/cast time may be cast here apparently SC doesn't have a travel time in SimC
When running simParser with a json file using profileSets with stat weights you get this error:
Traceback (most recent call last):
File "simParser.py", line 103, in <module>
main()
File "simParser.py", line 97, in main
parses += parse(filename, options.csv, options.hideHeaders, options.hideProfiles, options.hideActors, options.dpsOnly)
File "simParser.py", line 37, in parse
ret+= parseProfileSets(filename, isCsv, hideHeaders, hideProfiles, hideActors, dpsOnly)
File "simParser.py", line 48, in parseProfileSets
if dpsOnly or 'Int' in profile['scale_factors']:
KeyError: 'scale_factors'
Pastebin example json: https://pastebin.com/pH2XgkEd
Need charts for this page: https://warcraftpriests.com/?p=1547&preview=true
Need the spec specific traits implemented for shadow. Assuming the general ones will be implemented by someone else?
Is your feature request related to a problem? Please describe.
Reduce duplicate code by combining reports.py into a single file across all folders
Describe the solution you'd like
A single reports.py file in the root of the repo that works with analyze.py and sim.py
Describe the bug
Analyze.py currently adds all Base actors together, these should be divided by the number of actors to get the right amount. This cannot be done until all fight profiles are done.
Expected behavior
Base actor shouldnt have an int weight higher than 1.
Need to add this trinket to simc + trinket sims:
http://www.wowhead.com/item=163937
Before adding need a table that maps shadow spells to buff.
CodeFactor found multiple issues last seen at 93dd259:
if=talent.dark_void.enabled
Some trinkets in simc do not behave as they do in game currently. The sheet I made helps address this.
Compare values from in game data (logs) and make sure simc and the sheet both match these values
Some trinkets are hilariously overpowered at the moment and skew results. For example, there's a trinket that erroneously has 100% uptime, which greatly inflates it.
Need to create a spreadsheet to analyze racial bonuses data
Mythic raid gear drops at 385, need to determine titanforge cap and add the extra ilvls of all trinkets to that point for the launch of BfA.
It's semi difficult to look through the charts and find out which trait is best in comparison to others
Solution: Potentially Seperate out by tier and use only 1 trait of each rather than a stack of 2 or 3.
Describe the bug
Occasionally raidbots will error out, or the script will error. If an error occurs when submitting, polling, or pulling the result of a sim the script should auto retry.
To Reproduce
Run a sim and wait for raidbots to error
Expected behavior
I expected the script to detect the error neatly, and retry the sim without flooding the terminal output.
Spreadsheets
N/A
Additional context
N/A
If thought harvester rank is greater than 0, investigate if it is worth to vampiric touch before casting mind blast if the buff is inactive
Need to build out sims/analyze data for best gear combinations for the T22 profiles.
Is your feature request related to a problem? Please describe.
Need to determine if it is worth it to dump MB/SWV charges before using DA
Describe the solution you'd like
If you are out of voidform, before popping DA the actor should use all available Mind Blast or SW:V charges.
Additional context
If you pop DA at 0 insanity it'll shorten that Voidform
CodeFactor found an issue: Starting a process with a shell, possible injection detected, security issue.
It's currently on:
Need to create a spreadsheet to analyze enchant data
Add a glossary for commonly used terms for Shadow, Priest, WoW, and SimC in general.
Need to create a spreadsheet to analyze consumable data
Steps to add dungeons:
--dungeons
flag--dungeons
flagIf a sim has a weight of 0, it should not sim it. After this change need to confirm analysis.py still works as expected.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.