seancarroll / jfluentvalidation

Fluent Validation for Java

Hi there 👋

Projects

Contact

You can find me on Twitter @seancarroll_ or Mastodon hachyderm.io/@seancarroll

jfluentvalidation's Issues

Cache ByteBuddy Proxies

We should cache ByteBuddy dynamic proxies created in PropertyNameExtractor

Add Additional Methods to MapSubject

Potential candidates

• doesNotContainKey
• doesNotContainKeys
• containsOnlyKeys
• containsValue
• containsValues
• doesNotContainValue
• containsOnly(Map.Entry<? extends K, ? extends V>... entries)
• isEqualTo
• isIn(Iterable<?> values)
• isIn(Object... values)
• isNotEqualTo
• isNotIn(Iterable<?> values)
• isNotIn(Object...values)
• hasEntrySatisfying(K key, Condition<? super V> valueCondition)
• hasEntrySatisfying(K key, Consumer<? super V> valueRequirements)
• hasEntrySatisfying(Condition<? super Map.Entry<K, V>> entryCondition)
• hasEntrySatisfying(Condition<? super K> keyCondition, Condition<? super V> valueCondition)
• hasKeySatisfying(Condition<? super K> keyCondition)
• hasValueSatisfying(Condition<? super V> valueCondition)
• satisfy/satisfyrequirements (See assertj)

Should Support arrays for Primitive Array Subjects Methods That Take In Iterable

Example, currently IntArraySubject containsExactly supports containsExactly(Integer... expected) and containsExactly(Iterable<Integer> expected). We should also support passing in an array

Allow for Temporal Tolerance For Date/Time Validations

Hibernate Validator 6.0.5 introduced Temporal Validation Tolerance which is described as

the acceptable margin of error when comparing date/time in temporal constraints.

I think it makes sense to include something like this as well

Set up Project In Maven Central

Set up project in Maven Central so I can upload artifacts

Upgrade to JDK 17

I dont think there is a need to continue to use JDK 8. Lets move to 11

Improve ResourceBundleMessageInterpolator Performance

Right now we use regex, see TokenizedMessage, to parse messages. I think we can improve performance by implementing a solution that doesn't rely on regex. Hibernate Validator looks to have a decent implementation. See

• org.hibernate.validator.messageinterpolation.AbstractMessageInterpolator
• org.hibernate.validator.internal.engine.messageinterpolation.parser.TokenCollector
• org.hibernate.validator.internal.engine.messageinterpolation.parser.TokenIterator

Allow Users To Override Validation Messages

Users should be able to provide their own validation messages via user-provided message bundles similar to what Hibernate Validator allows.