seahorsepip / jpopup Goto Github PK

I think the z-index should be ~1500 to start off. The one in bootstrap is 1040.

I have a z-index of 180 on a relatively positioned navigation bar (becomes fixed with 200 z-index later on) and it overlays the background.

It doesn't necessarily need to be that high, but 0 is most likely insufficient in a lot of cases.

With 1500 it does as expected (although it may be a little large of a number respectively)

I was taking a look over the included css file and I noticed a few class redundancies.

https://github.com/seahorsepip/jPopup/blob/master/css/jpopup.css#L224-L227

When the popup is activated it currently adds the styling

position: fixed;
top: 0px;
width: 100%;
height: 100%;

on the HTML tag. This causes you to shoot back up to the top of the page.

I'd like to propose simply adding:

overflow: hidden;

to avoid this. May not be completely straightforward thought as I haven't tested this theory but I do something similar with mobile navigation on my personal site.