seadve / mpris-server Goto Github PK

(First: thanks a ton for the crate, I'm using it in my music player and it's nice not having to think about this stuff myself :) )

Now that async fn in traits has landed in stable Rust, I think it's possible to have the FooInterface traits use that instead of async_trait. If you're fine with an MSRV bump, then this is easy, but if you want to gate them behind a feature flag it gets trickier; features aren't supposed to introduce incompatible changes, so the simple answer of "add a native_async_trait feature that swaps them" doesn't work. You could have a macro_async_trait and native_async_trait features that are incompatible (with the first one enabled by default), or move the "native" ones into a separate submodule. I'm happy to do the actual implementation grunt work, but it's your library so I wanted to leave the design up to you.

Currently, user have to implement every functions on the trait.

Currently, we rely on zbus error types. We should implement our own so user won't have to import zbus, and make the error type clearer because zbus has one universal error type that has types that may not be relevant for some functions.