scopeinfinity / fuzzyos Goto Github PK

• Define Code Style
• Enforce Code Style using GitHub Actions
• Update CONTRIBUTING.md

• Define Code Style
• Enforce Code Style using GitHub Actions
• Update CONTRIBUTING.md

As for now va_arg increases the internal pointer by 4 bytes on each occurrence, which is not ideal if the argument passed size is different (ex. long long, double, long double or custom data structure using struct).

• src/usr/include/stdarg.h

A bit of additional context (if interested):

• Within FuzzyOS we are pushing arguments on the internal stack instead of relying on register arguments (default behavior).
  • We are overriding the default behavior using the -m32 flag of gcc.

This isn't a problem while passing char, short as they are auto promoted to int-size.

• Sample execution: https://godbolt.org/z/8xKM3e51r

Example PR for the unit-test for the implementation of <string.h>: #36

It will probably be better to make a tool around make configure

Source

• src/usr/lib/stdio.c

Specification

Source: https://en.wikipedia.org/wiki/Printf_format_string#Format_placeholder_specification

• syntax for a format placeholder: %[parameter][flags][width][.precision][length]type

To keep things simple we can go with the subset of the following options to build an minimum viable product

• Type field:
  • '%'
  • 'd' 'i'
  • 'u'
  • 'f' 'F'
  • 'g' 'G'
  • 'x' 'X'
  • 'o'
  • 's'
  • 'c'
  • 'p'
• Length field:
  • The field may be omitted (default, current behaviour)
  • 'l': 4 bytes same as 'not-specified'
  • 'll': 8 bytes
  • 'L': 96 bits? or bits?
    • https://en.wikipedia.org/wiki/Long_double#Implementations
    • https://godbolt.org/z/EME3zdcjG => 12 bytes == 96 bits
  • 'z': 4 bytes same as 'not-specified'
• Flags field:
  • The field may be omitted (default, current behaviour)
  • '-' minus
  • '+' plus
  • ' ' space
  • '0'
• Width field:
  • The field may be omitted (default, current behaviour)
  • or a numeric integer value
  • or a dynamic value when passed as another argument when indicated by an asterisk *.
• Precision field:
  • The field may be omitted (default, current behaviour)
  • or a numeric integer value
  • or a dynamic value when passed as another argument when indicated by an asterisk *.

Multiple small pull requests are way better than one giant one :)

Example PR for the unit-test for the implementation of <string.h>: #36

• int min(int a, int b);
• int max(int a, int b);
• int abs(int a);
• int atoi(const char *s)
• void itoa(int num, char *s, int base);
• void ftoa(double num, char *s);

• Define Code Style
• Enforce Code Style using GitHub Actions
• Update CONTRIBUTING.md