Coder Social home page Coder Social logo

scidsg-website's Introduction

scidsg-website's People

Contributors

deeplow avatar glenn-sorrentino avatar saptaks avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar  avatar

scidsg-website's Issues

Use semantic HTML tags

There are few items which I feel can benefit from better HTML tags. Ideally we can maybe update the CSS to be applied on tag instead of a class in the design system if there is a fixed style for the elements, but I don't mind keeping the designs in class instead of HTML tags. Some elements I noticed:

  • Highlighted text: Let's use <mark> for anywhere we are using highlighted text.
  • Striked out text: Let's use <s> for striked out text, e.g. prices
  • <div role="main"> : Let's replace this with <main>

Don't use `role=button` in anchor tags if it's supposed to be a link

role=button should be avoided as much as possible and instead the <button> tag should be used. It doesn't matter if a link aesthetically looks like a button. What really decides whether an interactive element is a button or a link is this:

  • Does clicking on it take you to a different page, or a different view, or a different section of the same page? It's a Link
  • Does clicking on it open a modal, switch a tab panel, toggle some item, open navigation in smaller screen? Basically it stays in the same page and doesn't go somewhere else. It's a Button

For example in the home page, all the "Learn More" links are given a role=button which is wrong since it goes to a separate page. So it's a link. We should remove all such role=button because it acts just like a <button> tag for assistive technology and confusing for users.

Refs: https://www.youtube.com/watch?v=8XjwDq9zG4I

Ensure landmarks are unique

In some pages like teams page or who-we-serve page, we have multiple <nav> elements for multiple navigations. It's best practise that if there are multiple elements of the same landmark, then one should add an aria-label to denote what each of these landmarks mean. So i think we can just update the HTML to add aria-labels, e.g.:

  • aria-label: "Main navigation" for the top navigation
  • aria-label: "Page navigation" for the tabs pointing to different sections of the page (Can suggest some other text as well which is more meaningful maybe @glenn-sorrentino ?)

Images have incorrect alt attribute

Describe the bug
In the "Who we server" page, the images under the "Areas of focus" have placehold alt text and not proper alt text.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://scidsg.org/who-we-serve.html#users
  2. Check the alt attribute of any of the images. They are all "Unless the image is decorative, add alt text."

Expected behavior
Images should ideally have a proper alt text, i.e. "avatar representing a journalist", "avatar representing an activist". If we are not too sure about the text, we can just remove them so that the images are treated as decorative and removed from the accessibility DOM tree.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.