schoekek / lgb_check_mk_plugins Goto Github PK

Hi,

there seems to be an issue with the ssllabs api check Plugin(downloaded from https://exchange.checkmk.com/p/ssllabs) in Checkmk 2.2.0. When I activate the plugin the following error message appears

Some GUI extensions could not be loaded. This may be caused by some incompatible extension packages.

Loading "wato/ssllabs_check_pameters" failed: name 'RegExp' is not defined

I then tried adding the check to a specific host and got the following error

[agent] Success, [special_ssllabs] TypeError: unsupported operand type(s) for +: 'PosixPath' and 'str'CRIT, [piggyback] Success (but no data found for this host), execution time 1.3 sec

Do you have an idea what could be wrong ?

Cheers

Hi,

i have installed this check on many hosts.
The most of my hosts are ubuntus.
Can you improve the detection of the lsb release?

I installed it on a proxmox server, its a virtualitzacion system, works on Debian and uses KVM and Qemu (proxmox.org)
the plugin is saying all the time "WARN - reboot required" but I have already rebooted it.

The check_mk client is Agent version 1.2.4p5, and (problably the problem) the kernel of proxmox is Linux px 2.6.32-34-pve x86_64 GNU/Linux

I've just commented this lines in the apt server code
if (reboot_req == "yes") and (level == 0):
level = 1
msg = "reboot required (!)"

now it works fine, but some bug is there.

Hallo Karsten,

Im Script lvs werden die variablen nicht zurückgesetzt. Dadurch wird die Gesamtzahl der Verbindungen immer weiter aufaddiert. DIe Variablen werden zwar am Scriptstart auf 0 initialisiert, aber in der Schleife der einzelnen LVS Hosts nicht mehr.

hello karsten,

In the script lvs the variables are not reset. This will add up the total number. The variables are initialized to 0 at the script start, but no longer in the loop of the individual LVS hosts.

        ## call IPVSADM and store output temporarily for further stringanalysis
        $IPVSADM -L -t $vip:$port | grep '^[ ].*[0-9].*$' > $TMPOUT
        SumActConn=0
        SumInActConn=0

        while read arrow host forward weight ActConn InActConn
        do
            # increment ActConn counter
            SumActConn=$SumActConn+$ActConn

            # increment InActConn counter
            SumInActConn=$SumInActConn+$InActConn

        done < $TMPOUT

When i remove the .py-files from ~/web/plugins/wato the error is gone.
Does sb know what i have to change?

Hi! I found some little bugs in your lvs plugin.

1. you writed in README: "Install the lvsgsp binary on /usr/local/sbin"
   but the agent (lvs script) searchs binary "lvsgsp" in /usr/local/bin;
2. (not really bug) the installation of package put the plugin under "/opt/omd/versions/$version/local/share/check_mk/agents/plugins/lvs"
   But if you want to show it in check_mk WATO interface under "Monitoring Agent" link, you have tu strip out "local" from above path.
   Then is better to put as First comment something shorter like "# LVS plugin", because it is showed as "link description".
3. The plugin does not work properly due to a sintax error on line 68:
   I changed it with:
   infotext = str(worst_state) + " - " + ', '.join(info_list)
   and now it seems to work.

Thats all for now ;)

After upgrading from 1.5.0p11.cee to 1.6.0p6.cee the plugin gives errors:

The "extension packages" page shows:
Loading "/omd/sites/nagios/local/share/check_mk/web/plugins/wato/apt_check_pameters.py" failed

And on the "services" page of a host:
Invalid check parameter: The type must be a dictionary, but it is a NoneType
Variable: checkgroup_parameters:apt
Parameters:

None

Hello

I have some servers with more than one website on it (and of course, different ssl certificates). I configured everything, but it appear only the first site I configured. All other sites are not listed/detected.

Greetz

Hi,

I noticed that the version of the ssllabs plugin on the Checkmk Exchange is newer than the one in this repo.
Would you mind uploading it here?

Regards,
Moritz

Hi Karsten,

following situation:

• added apt-2.7
• "manual checks -> apt" for all debian hosts
• activate changes

...APT services are shown for all debian hosts like expected. Now some times later delete the plugin from one debian host...

The APT service will show something like "Debian 0.0, all updates done" (I do not know the exact wording).

The issue can be found in the check file. Here the check is done even if no info is provided (no <<>> section.

Working patch:

`45,51c45,52
<     apt_upgrades = {}
<     level        = 0
<     msg          = ""
<     updates      = 0
<     crit_updates = 0
<     deb_release  = 0.0
## <     reboot_req   = "no"

> ```
> if info:
>     apt_upgrades = {}
>     level        = 0
>     msg          = ""
>     updates      = 0
>     crit_updates = 0
>     deb_release  = 0.0
>     reboot_req   = "no"
> ```
> 
> 53,56c54,57
> <     # Parse the agent output
> <     if len(info) > 0:
> <         deb_release  = info[1][0]
> ## <         reboot_req   = info[0][0]
> 
> ```
>     # Parse the agent output
>     if len(info) > 0:
>         deb_release  = info[1][0]
>         reboot_req   = info[0][0]
> ```
> 
> 58,59c59,60
> <     if len(info) > 2:
> ## <         packages  = info[2:]
> 
> ```
>     if len(info) > 2:
>         packages  = info[2:]
> ```
> 
> 61,68c62,69
> <         for package in packages:
> <             name   = package[0]
> <             updates += 1
> <             source = package[1].split(' ')[0].split(':')[0]
> <             if source in apt_repository_severity:
> <                 severity  = apt_repository_severity[source]
> <             else:
> ## <                 severity  = apt_repository_severity['**default**']
> 
> ```
>         for package in packages:
>             name   = package[0]
>             updates += 1
>             source = package[1].split(' ')[0].split(':')[0]
>             if source in apt_repository_severity:
>                 severity  = apt_repository_severity[source]
>             else:
>                 severity  = apt_repository_severity['__default__']
> ```
> 
> 70,71c71,72
> <             if severity >= 2:
> ## <                 crit_updates += 1
> 
> ```
>             if severity >= 2:
>                 crit_updates += 1
> ```
> 
> 73c74
> ## <             level = max(level, severity)
> 
> ```
>             level = max(level, severity)
> ```
> 
> 82,89c83,92
> <     if (reboot_req == "yes") and (level == 0):
> <         level = 1 
> <         msg = "reboot required (!)"
> < 
> <     if level > 0:
> <         return (level, "%s" % msg)
> <     else:
> ## <         return (level, "Debian %s all packages are up to date" % deb_release)
> 
> ```
>     if (reboot_req == "yes") and (level == 0):
>         level = 1 
>         msg = "reboot required (!)"
> 
>     if level > 0:
>         return (level, "%s" % msg)
>     else:
>         return (level, "Debian %s all packages are up to date" % deb_release)
> 
> return (3, "No apt data found in agent output!")
> ```
> 
> <\code><\pre>

Regards,
Marcel

I'm trying to run this on 1.2.8p18 CEE. I've got it installed and can configure it, however when I configure it to run on one of my check_mk servers, it prevents all other services from being returned so it appears that the server only has a ping check.

+ echo '<<<apt>>>'
<<<apt>>>
++ cat /etc/debian_version
++ cut -d . -f1
+ DEBIAN_VERSION=7
+ DEB6_RE='^\S+ \S+ \S+ \(Debian ([^\)]+)\).*$'
++ dpkg-query -W '-f=${Version} ${Status;20} ${Maintainer} ${Provides}\n'
++ grep linux-image
++ grep 'install ok installed Debian Kernel Team'
++ awk '{ print $1 }'
+ KERNEL_PACKAGE='2.6.32-48squeeze13
3.2.68-1+deb7u3'
++ cat /proc/version
+ KERNEL='Linux version 3.2.0-4-amd64 ([email protected]) (gcc version 4.6.3 (Debian 4.6.3-14) ) #1 SMP Debian 3.2.68-1+deb7u3'
+ [[ 7 == \6 ]]
+ [[ 7 == \7 ]]
++ echo 3.2.68-1+deb7u3
+ KERNEL_VERSION=3.2.68-1+deb7u3
+ [[ 2.6.32-48squeeze13
3.2.68-1+deb7u3 == 3.2.68-1+deb7u3 ]]
+ echo yes
yes
+ cat /etc/debian_version
7.8

Technically it's dieing because of not handling multiline output. You'll need some quotes.
It might also hint at a logic issue, the newest kernel was the one running. It can only be "OK" in that case.

As topic implies - current check is not working with Checkmk 2.0:

File "/omd/sites/mysite/local/share/check_mk/agents/special/agent_ssllabs", line 19, in
from cmk.utils.paths import tmp_dir
ImportError: No module named cmk.utils.pathsCRIT
ignored: systemtime: System Time