schemaplus / schema_plus_views Goto Github PK

This is a great gem, I use it all the time.

When schema.rb is created, the SQL view is inserted in alpha order. This means that if there is a later table in the schema.rb file which the view depends on, rake db:reset will fail as the dependent object is not created when the create_view is called.

The workaround is to manually edit the schema.rb file after any migrations are run, and move the views down.

Any suggestions on how to automate this? It could be further complicated if views depend on views, but if all the views we added to schema.rb after all the tables, it would solve 90% of the problems.

Hi guys,
just wondering if you guys are thinking to update this gem to be compatible with rails 5.2?

Sent a PR to do so but no luck with the tests: #17

Any help here is appreciated

thanks

Currently the view's are being created in the schema that matches my username, and not in the public schema where the rest of my rails data is location.

In the database schema, the view looks like this:

CREATE OR REPLACE VIEW usersx AS
SELECT users.id,
users.client_id,
users.username,
users.firstname

With the schema_plus_views gem, the schema.rb looks like this:

CREATE OR REPLACE VIEW usersx AS
SELECT users.id,\n users.client_id,\n users.usernam\n, users.firstname\n ...

postgresql
rake 10.4.2
rails 4.2.0
ruby 2.2.1p85
osx yosemite

If project doesn't have mysql2 loaded it creates Mysql2Adapter as a module and causes issues

>> ActiveRecord::ConnectionAdapters::Mysql2Adapter
SchemaPlus::Views::ActiveRecord::ConnectionAdapters::Mysql2Adapter

In projects that have mysql2 it works correctly:

>> ActiveRecord::ConnectionAdapters::Mysql2Adapter
ActiveRecord::ConnectionAdapters::Mysql2Adapter < ActiveRecord::ConnectionAdapters::AbstractMysqlAdapter

just for my information. why do you use method to_json in this place?

class View < KeyStruct[:name, :definition]
   def assemble(stream)
        heredelim = "END_VIEW_#{name.upcase}"
        stream.puts "  create_view #{name.to_json}, <<-#{heredelim}, :force => true\n"
        definition.split("\n").each { |line| stream.puts line.to_json[1...-1] + "\n" }
        stream.puts "  #{heredelim}\n\n"
    end
end

if view contains fields from an json column in pg table in schema db i get unicode lines like that

 ((details -\u003e\u003e 'cost'::text))::numeric(10,2) AS cost

I have an issue when defining views with joins between two postgres schemas (e.g. public and client_a).

Suppose we have this view definition:

CREATE VIEW my_view AS SELECT plans.name, clients.id
FROM clients 
JOIN public.plans ON plans.id = clients.plan_id

Then then the following SQL is stored in db/schema.rb (notice missing public prefix for plans):

SELECT plans.name, clients.id
FROM clients 
JOIN plans ON plans.id = clients.plan_id

I'm using this in combination with the apartment gem which loads schema.rb file for every tenant it creates. It also creates all tables for every schema/tenant, even if they are only used in the public schema.

The query to get the views:

Not sure how to proceed yet. The views generated by migrations are correct.
Basically I want the "exluded model tables" from apartment to be prefixed with public in the db/schema.rb while the others use search_path.

Would that be very difficult or not work for some reason?

I am using postgis, when I setup by schme.rb will throwing following error:

ActiveRecord::StatementInvalid: PG::DependentObjectsStillExist: ERROR:  cannot drop view raster_columns because extension postgis requires it

I do not wanna to drop the postgis views

ACTUAL BEHAVIOR
without schema_plus_views gem

create a migration to create table users if you don't have one
or
create any test migration for a different table (not users) if you already have users
rake db:migrate
create users... added to schema (or still there if it was already there)
create a migration for usersx view
rake db:migrate
users table still in schema
usersx view is not added to schema (standard rake behavior)

add schema_plus_views gem to gemfile
bundle
create any test migration for a different table
rake db:migrate
create view usersx... added to schema as expected with gem
create users table... not in schema

EXPECTED BEHAVIOR
create view usersx in schema
create table users in schema