schdck / simpledialogs Goto Github PK

Since CanClose was removed, the dialog buttons are now always enabled. It would be nice to have a way to disable them instead of just prevent the dialog from closing when the button is clicked.

Update the readme screenshots and the Wiki to match the v2.0.

When the property CloseOnButtonClickByDefault is set to false, the event ButtonClicked is never raised.

When trying to show a dialog before the first DialogContainer is created, there's no one subscribed to DialogManager, so it sillently fails (no exception is thrown, because it is configured to just return null).

I think this behavior is very confusing and should be changed. Right now, I think the possibilities are:

• Option A: Throw an exception instead of just returning null (this could be usefull when the user forgot to create a DialogContainer, but would make the process of showing a dialog before the window was created very painful¹)
• Option B: Add the shown dialog to the Stack and display it as soon as someone subscribe

In case we choose Option B, something to keep in mind is: what Task to return from ShowDialogAsync/ShowDialogForResult? Since the Stack is implemented on the DialogContainer and there's none, another Stack would need to be implemented on the DialogManager.

¹ Imagine a scenario where the application loads some data on startup and it fails. So you catch the exception and try to display a dialog with it, but your window is not yet initialized (because your application is just starting up). As I see, if we were to thrown an Exception, user would need to either move the load data code to after the Window is initialized and the DialogContainer is created (which can be good sometimes, but is not something I want to force on users) or just show the dialog after the DialogContainer is created (which is almost the same thing as Option A, but done in the the end-user code instead of here)

Since the BaseDialog is an WPF component, it would be nice if there was a way of launching a dialog from a ViewModel without referencing it directly.

This way the user would not be bothered by having to call the BaseDialog() constructor from a STA thread, etc.

Hi,

Well done for your awesome work !
Is there a way or input property to set wildcard character when typing password on the input dialog ?

Best regards,
Clem

I realised (and am very disappointed with myself for not doing so earlier) that getting the content out of the ContentControl and adding it to a brand-new Grid (or even another ContentControl) is not a really good idea and can cause a lot of unwanted behavior (think of e.g. ContentTemplate property) and the cost-benefit of implementing something to prevent such behaviors is not worth it. The same applies to adding a child to an Panel that is not a Grid without any row or column definitions.

I am not sure yet, but I think the best move is to create a control to host the dialogs.. So that's probably what's going to happen by the next release.

Add details of all inner exceptions when copying details to clipboard

Add option to automatically set the focus to the dialog's button when it is shown

Add option to auto close the dialog after n seconds.