TypeError on manipulating queries about fsql

[sbuberl]

Hello,

Thanks for the report. What version were you using? Or were you using cloned version of this repo?

Steve

[pocketoffice]

hi

yes, i use a cloned version of this repo.
meanwhile i think i've found whats causing the error, at least changing CachedTable.php Line 229 from
$entries = null;
to
$entries = array();
does let me insert without errors.

[sbuberl]

Good catch. Possibly some legacy code I didn't notice. So $entries was assigned to empty array if table was not empty, but for empty tables, it was using that NULL. I pushed the fix.

Unfortunately my unit tests are only at like 50% code coverage. Mostly CREATE and SELECT tests.
Otherwise, that definitely would been caught by an INSERT test. If I have some free time this weekend, hopefully I can work on some tests.

[sbuberl]

I apparently had a test for this in CachedTableTest for the class level test. But I was checking whether the returned entries were empty (as in the php function "empty"). So both null and empty arrays were passing the test. I pushed a fix for the test as well so only empty arrays pass.

Hopefully I'll still work on adding new tests this weekend.