sayakie / hakase Goto Github PK

Discord bot to let y'all explore Pixelmon Pokémon information built around Discord Interactions.

License: MIT License

JavaScript 5.62% TypeScript 92.90% Dockerfile 1.48%

pixelmon pokemon pokedex pixelmon-reforged bot discord discord-bots discord-js-bot hacktoberfest pokedex-application

hakase's Introduction

#! /bin/bash
+ $ ./whois Sayakie -- --compact

-   I am a vanguard who explores things about I'm curious about. In 2021, I'm interesting and falling with Flutter, Dart!
- Also I want to learn Rust, Go and Kotlin if I have enough time. Actually, I'm a greedy man (〃▽〃)

side projects

LunchVue (2018)
An pack of web server that can fetch Korea elementary, middle and high school's meals.
Pixiv Crawler (2019)
Unofficial library that crawls images from Pixiv. Provide useful options for determinig whether to fetch by tags, date or more other!
Unicode Blocks (2020)
Provides unicode scoping blocks.
Feeder (2021)
Subscribe about tech·development daily stories through GitHub Actions. Support both Discord and Slack due to using Webhook!
properties-translator (2021)
Progressive web program that provides a tool to translate properties or lang files.
Hakase (2021)
Use the advanced search to explore Pixelmon Reforged Pokémon by type, weakness, ability, and more in Discord!
clova (Private; Claimed) (2022)
Create a mirror-question in Minecraft or Discord. Client can interact with those questions, join or opt out freely, and obtain an answer.
icyonline-monorepo (Private; Claimed) (2022)
Monorepo for ICY Online bots interacting with Discord API. Improves management performance, enchants powerful experience to the users who are serviced by ICY Online Discord server.
TriggerReactor/wiki-bot (2022)
Discord slash command utilities for TriggerReactor developer support.
dareharu/node-template (2022)
Template to be used for Dareharu Project repositories.
dareharu/haru (2022)
A framework, library, plugin, and mod for Haru Server.

co-op projects

Pixelmon (2021 ~ )
TriggerReactor/TriggerReactor (2022 ~ )

hakase's People

Contributors

Stargazers

Watchers

Forkers

marmarj

hakase's Issues

Gradually merge the declaration file "hakase" into the source codebase

ESLint does not interpret Hakase/index.d.ts, might be there is a solution to solve. But we decide deprecate the declaration and merge that into source codebase.

If

Already provided by discord.js. Should be removal in next major release.

Hakase/typings/hakase/index.d.ts

Lines 1 to 5 in 3948378

    
           declare type If<T extends boolean, A, B = null> = T extends true 
        
             ? A 
        
             : T extends false 
        
             ? B 
        
             : A | B

Action Required: Fix Renovate Configuration

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: Preset is invalid JSON (github>dareharu/renovate-config)

pokedex on every species is broken

Why..

Hakase/src/entity/Species.mts

Lines 93 to 121 in ce84c06

    
           public static readonly MissingNo = this.#impl.of(0, `MissingNo`) 
        
           public static readonly Bulbasaur = this.#impl.of(1, `Bulbasaur`) 
        
           public static readonly Ivysaur = this.#impl.of(2, `Ivysaur`) 
        
           public static readonly Venusaur = this.#impl.of(3, `Venusaur`) 
        
           public static readonly Charmander = this.#impl.of(4, `Charmander`) 
        
           public static readonly Charmeleon = this.#impl.of(5, `Charmeleon`) 
        
           public static readonly Charizard = this.#impl.of(6, `Charizard`) 
        
           public static readonly Squirtle = this.#impl.of(7, `Squirtle`) 
        
           public static readonly Wartortle = this.#impl.of(8, `Wartortle`) 
        
           public static readonly Blastoise = this.#impl.of(9, `Blastoise`) 
        
           public static readonly Caterpie = this.#impl.of(0, `Caterpie`) 
        
           public static readonly Metapod = this.#impl.of(1, `Metapod`) 
        
           public static readonly Butterfree = this.#impl.of(2, `Butterfree`) 
        
           public static readonly Weedle = this.#impl.of(3, `Weedle`) 
        
           public static readonly Kakuna = this.#impl.of(4, `Kakuna`) 
        
           public static readonly Beedrill = this.#impl.of(5, `Beedrill`) 
        
           public static readonly Pidgey = this.#impl.of(6, `Pidgey`) 
        
           public static readonly Pidgeotto = this.#impl.of(7, `Pidgeotto`) 
        
           public static readonly Pidgeot = this.#impl.of(8, `Pidgeot`) 
        
           public static readonly Rattata = this.#impl.of(9, `Rattata`) 
        
           public static readonly Raticate = this.#impl.of(0, `Raticate`) 
        
           public static readonly Spearow = this.#impl.of(1, `Spearow`) 
        
           public static readonly Fearow = this.#impl.of(2, `Fearow`) 
        
           public static readonly Ekans = this.#impl.of(3, `Ekans`) 
        
           public static readonly Arbok = this.#impl.of(4, `Arbok`) 
        
           public static readonly Pikachu = this.#impl.of(5, `Pikachu`) 
        
           public static readonly Raichu = this.#impl.of(6, `Raichu`) 
        
           public static readonly Sandshrew = this.#impl.of(7, `Sandshrew`) 
        
           public static readonly Sandslash = this.#impl.of(8, `Sandslash`)

Duplicate spawn times appeared for some pokemons

E.g. Diancie displays Morning, Morning in spawn times field.

Provide variant, or alter forms (gigantamax) description

⭐ Suggestion

Each Pokémons have its unique variance forms like mega, alolan, galarian, hisuian, or gigantamax. The Pokedex has a detailed description, but at the same time, Hakase does not have a description.

So I suggest that it would be good to provide more detailed information to users.

Examples

Input  > /Pokemon Charizard
Output > It spits fire that is hot enough to melt boulders. It may cause forest fires by blowing flames.

Input  > /Pokemon Charizard (Mega-X)
Output > The overwhelming power that fills its entire body causes it to turn black and creates intense blue flames.

Input  > /Pokemon Charizard (Gigantamax)
Output > This colossal, flame-winged figure of a Charizard was brought about by Gigantamax energy.

Additional Informative

Proposer: 윤동현 on the Discord

Relevant Issues

No context

Applin prints invalid evolution entities

`#prepareStat()` breaks consistent Stat structure

Reproduce steps

If the given stat does not have a forms property or which equivalent to an empty object, the method early returns without overwriting bounding_box to boundingBox.

Hakase/src/util/loader/statLoader.ts

Lines 23 to 26 in bcb7dcf

    
           function prepareStat(stat: Stat): Stat { 
        
             if (!stat.forms || Object.keys(stat.forms).length <= 0) { 
        
               return stat 
        
             }

Invalid evolution spec returns with all of had Gender pokemons

Pikipek groups prints invalid evolution entities order

Add husky and conventional commits

Some legendary need extra spawn set

Target Pokemons:

via Timespace Altar: Arceus, Dialga, Palkia
any: Heatran

Hakase Refactoring Roadmap

Roadmap Preview

디스코드 Basixlounge 서버에서 받은 코드 리뷰를 토대로 리팩토링 로드맵을 작성했습니다.
아래의 코드를 전부 리팩토링하는 것이 이 로드맵의 최종 목표입니다.

누락된 return 추가하기
[File]: PokemonUtil.ts#L151
PokemonUtil.ts에서 반복되는 importing 작업을 초기화 페이즈만을 담당하는 다른 파일로 옮기기
[Files]: PokemonUtil.ts#L12-#L58
인스턴스화를 방지하기 위해 클래스에 null을 확장하는 것을 걷어내기
[Benefits]: UB에 준하는 동작을 미리 걷어냄으로써 미래에 야기될 수 있는 문제를 방지합니다.
[Drawbacks]: 타입스크립트를 컴파일한 뒤 런타임에서 클래스를 인스턴스화 할 수 있습니다.
[Files]: ArrayUtil.ts#L5 / Util.ts#L871 / PokemonUtil.ts#L101
[Reference]: tc39/ecma262#1321
조사(은는이가)를 구하는 함수를 문자열 헬퍼 함수를 제공하는 StringUtil.ts 파일에 따로 분리시키기
[File]: PokemonUtil.ts#L73-#L99
타입 단언한 코드들을 타입 추론으로 옮기기
[Benefits]: 타입을 명시하는 의미가 더 명확해집니다.

=== Example)
- const dropItemLengthOrder = {} as { [P in Extract<keyof PokeDrop, `${string}data`>]: number }
+ const dropItemLengthOrder: { [P in Extract<keyof PokeDrop, `${string}data`>]: number } = {}

Circular dependency error

All variant forms(EnumAegislash, EnumAlcremie, etc...) throw a reference error like the following output:

ReferenceError: Cannot access 'FormBelongToSpecies' before initialization

Note: We use Node.js but do not follow the CommonJS module system (instead ECMAScript module system)

Support for Node.js v17

When install dependencies, Node throws unsupported Node.js version using v17.

Bump Pixelmon 8.3.8

Add Pokemon Wyrdeer to Species
Add husuian form for Pokemon Growlithe and Braviary

`Species.legendaries` and `Species.ultrabeasts` always return an empty array

Reading Species#legendaries and Species#ultrabests will always return an empty array that its length is 0.