saw303 / grails-ic-alender

iCalender Plugin for Grails

Hello 👋🏻,

My name is Silvio. I'm a software developer and architect working in Zurich, Switzerland. I'm a co-founder of onstructive.

grails-ic-alender's Issues

Extraneous notifications printing to terminal

Messages such as the following are displayed to the terminal:

Modifying render method on controller 'Account'

The messages originate from a println statement in ICalendarGrailsPlugin.groovy. Switching to a log.info statement would be cleaner.

Support for attendees

Please add support for adding attendees to events.

Dependencies of ical4j:2.0.0 kill application with Spring security

New version (0.6.1) dependancies

+--- org.grails.plugins:iCalendar:0.6.1
| --- org.mnode.ical4j:ical4j:2.0.0
| +--- org.slf4j:slf4j-api:1.7.10 -> 1.7.21
| +--- org.apache.commons:commons-collections4:4.0
| +--- org.codehaus.groovy:groovy-all:2.3.2 -> 2.4.7
| +--- biz.aQute.bnd:bndlib:2.3.0
| | --- org.osgi:org.osgi.core:4.3.1
| +--- org.apache.commons:commons-lang3:3.3.2
| --- commons-codec:commons-codec:1.9

10Mb of new dependencies =)

Previous (0.6.0)

org.grails.plugins:iCalendar:0.6.0
| --- org.mnode.ical4j:ical4j:1.0.7
| +--- commons-logging:commons-logging:1.1.3 -> 1.2
| +--- commons-codec:commons-codec:1.8 -> 1.9
| +--- commons-lang:commons-lang:2.6
| --- backport-util-concurrent:backport-util-concurrent:3.1

Grails 3.1.15
The problem reproducible only on tomcat

Now I'm trying to exclude dependencies, without success.

compile ('org.grails.plugins:iCalendar:0.6.1'){
exclude group:'org.slf4j'
exclude group:'biz.aQute.bnd'
exclude group:'org.codehaus.groovy'
exclude group:'commons-codec'
}

Is it possible rollback dependencies ?

Can't specify an "all-day" event

Is there a way to specify that an event is all-day? I looked at your code and it seems like the start and end dat and time are getting parsed no matter what. I looked into the underlying calendar and it seems from the javadoc of ical4j that you can specify an "all-day" event by only specifying the STARTDATE on the VEvent.

I'm going to attempt a workaround by just creating a Events using the underlying calendar for my types that require all day events, but it would be nice to just do it the Groovy way with your iCalendarBuilder class.

Unable to install latest releases (0.4.3 and 0.4.2)

I am unable to upgrade from 0.4.0 to releases 0.4.3 or 0.4.2. The plugins cannot be found.

Repository config:

    repositories {
        grailsPlugins()
        grailsHome()
        grailsCentral()
    }

Given:
compile ":ic-alendar:0.4.3"

Produces:

        ::::::::::::::::::::::::::::::::::::::::::::::
        ::          UNRESOLVED DEPENDENCIES         ::
        ::::::::::::::::::::::::::::::::::::::::::::::
        :: org.grails.plugins#ic-alendar;0.4.3: not found
        ::::::::::::::::::::::::::::::::::::::::::::::

Given:
compile ":ic-alendar:0.4.2"

Produces:

        ::::::::::::::::::::::::::::::::::::::::::::::
        ::          UNRESOLVED DEPENDENCIES         ::
        ::::::::::::::::::::::::::::::::::::::::::::::
        :: org.grails.plugins#ic-alendar;0.4.2: not found
        ::::::::::::::::::::::::::::::::::::::::::::::

Setting version to 0.4.0 installs fine.

I am using grails version 2.3.5

Is there a way to set the custom uid for an event ?

I cant find a way to do this, as I also want to update the events. On ICalendarBuilder.groovy:156, I see:

currentEvent.properties << new UidGenerator(null, 'iCalPlugin-Grails').generateUid()

This makes me think that it may be just hard coded. Am I right ? The idea is to update an event by setting the same uid in an event.

Is there a method to cancel an event?

Hi,

in iCal4j it is possible to cancle an Event. Is there already a method implemented?

Best regards

Tobias

Modifying render method on controller ...

Is there any way to restrict the activation of this plugin to only the controllers where we need it? We are seeing in the log that it is modifying every render on every controller.

Add Update/Cancel event support

For update and delete of event STATUS, METHOD, SEQUENCE field is required
http://stackoverflow.com/questions/45453/icalendar-and-event-updates-not-working-in-outlook

METHOD filed supported only in event, not calendar.

commas are rendered in a strange way

hi kindly developers,

first of all thank you for developing this great plugin.

I have the problem that if in the description or the summary (maybe somewhere else too) of an event is a comma, the output of the comma is rendered as ,

e.g.

def test() {
        renderCalendar {
            calendar {
                events {
                    event(start: Date.parse('dd.MM.yyyy HH:mm', '01.11.2009 14:00'),
                    end: Date.parse('dd.MM.yyyy HH:mm', '01.11.2009 15:00'),
                    description: 'hell, yes',
                    summary: 'Short, info2',
                    location: '@home',
                    classification: 'private'){
                        organizer(name: 'Silvio Wangler', email: '[email protected]')
                    }
                }
            }
        }
    }

is rendered as

BEGIN:VCALENDAR
PRODID:-//Grails iCalendar plugin//NONSGML Grails iCalendar plugin//EN
VERSION:2.0
CALSCALE:GREGORIAN
METHOD:PUBLISH
BEGIN:VEVENT
DTSTAMP:20180108T110609Z
DTSTART;TZID=Europe/Zurich:20091101T140000
DTEND;TZID=Europe/Zurich:20091101T150000
**SUMMARY:Short\\, info2**
UID:20180108T110609Z-iCalPlugin-Grails@fe80:0:0:0:6cb2:d4ff:fe2a:3be4%awdl0
TZID:Europe/Zurich
LOCATION:@home
**DESCRIPTION:hell\\, yes**
CLASS:PRIVATE
ORGANIZER;CN=Silvio Wangler:mailto:[email protected]
METHOD:PUBLISH
END:VEVENT
END:VCALENDAR

Is this a bug or is there a way to get over it?

Kind regards
Dietmar

DTSTART and DTEND do not have their TZID property set

DTSTART and DTEND do not have their TZID property set when a timezone is provided.

Expected:

DTSTART;TZID=America/Toronto:20150201T090000
DTEND;TZID=America/Toronto:20150201T090000

Actual:

DTSTART:20150201T090000
DTEND:20150201T090000

Cause:
The date instances are created with the DateTime(String value, String pattern, TimeZone timezone) constructor and passed a timezone, but this timezone is not assigned to the DateTime instance's timezone property:

From ICalendarBuilder.groovy:

private void handleEventNode(Map params, nodeName) {
    ...

    def startDate = new DateTime(params.start.format(dateFormat), dateFormat, timezone)
    def endDate = new DateTime(params.end.format(dateFormat), dateFormat, timezone)

    startDate.setUtc(isUtc)
    endDate.setUtc(isUtc)

    currentEvent = new VEvent(startDate, endDate, params.summary)

    ...

From iCal4j:

    public DateTime(String value, String pattern, TimeZone timezone)
            throws ParseException {
        // setting the time to 0 since we are going to reset it anyway
        super(0, Dates.PRECISION_SECOND, timezone != null ? timezone
                : java.util.TimeZone.getDefault());
        this.time = new Time(getTime(), getFormat().getTimeZone());

        final DateFormat format = CalendarDateFormatFactory
                .getInstance(pattern);
        setTime(value, format, timezone);
    }

If you explicitly set the timezone then the TZID property gets added to DTEND AND DTSTART:

    startDate.setTimeZone(timezone);
    endDate.setTimeZone(timezone);

Suggested from the iCal4j documentation

Added categories to the ICalendarBuilder.groovy

Great plugin thank you.

I needed categories compliant from (http://tools.ietf.org/html/rfc5545) for my ics files so I added a line of code to your groovy file. I was hoping you could add this in your next version.

       /*
       set internet address to null otherwise it takes awful lots of time to resolve a hostname or ip address
        */
        currentEvent.properties << new UidGenerator(null, 'iCalPlugin-Grails').generateUid()
        currentEvent.properties << tz.timeZoneId
        if (params.location) currentEvent.properties << new Location(params.location)
        if (params.description) currentEvent.properties << new Description(params.description)
        if (params.categories) currentEvent.properties << new Categories(params.categories)
        if (params.classification) currentEvent.properties << getClazz(params.classification)
        currentEvent.properties << new Organizer()
        this.cal.components << currentEvent

Example use:

event(start: Date.parse('dd.MM.yyyy HH:mm', '31.12.2013 14:00'),
    end: Date.parse('dd.MM.yyyy HH:mm', '31.12.2013 15:00'),
    description: 'Football game this Saturday',
    summary: 'Football game',
    categories: 'Football',
    location: 'Field B')
    {
        organizer(name: 'Mr Football', email: '[email protected]')
    }

Thanks again.

A new UidGenerator is being created for each event causing many hostname lookups

When generating many events at a once, there is a large spike in DNS traffic. After digging through the source, I noticed that a new UidGenerate is created for each event:

currentEvent.properties << new UidGenerator('iCalPlugin-Grails').generateUid()

Looking at the constructor implementation of the net.fortuna.ical4j.util.UidGenerator, you can see that this will create a new InetAddressHostInfo each time, instead of allowing it to just use a cached copy:

    /**
     * @param pid a unique process identifier for the host machine
     * @throws SocketException where host information cannot be retrieved
     */
    public UidGenerator(String pid) throws SocketException {
        this(new InetAddressHostInfo(), pid);
    }

If the UidGenerator was created once per ICalendarBuilder, there would be far less reverse name lookups performed.

Support for UTC export

Hi,

First of all, great plugin. Extremely useful, and easy to use.

As far as I can tell, there's no current way to export start and end event dates in UTC format. Is that right? Poking around your code and the iCal4J forums seems to indicate that to do so the "setUtc" method would need to be called on the DateTime objects.

If you know any work arounds to get this to work or alternate approaches I would love to hear about it.

Thanks again,
David

Invalid plugin error for v0.3.6

We just attempted to update to the latest version of the plugin with:

compile ":ic-alendar:0.3.6"

The grails compile command now aborts with the message:

Error Zip /Users/dpilafian/.grails/ivy-cache/org.grails.plugins/
ic-alendar/zips/ic-alendar-0.3.6.zip is not a valid plugin

The error message is not particularly informative. If there's other information that would be helpful, just let me know.

If the calendar has multiple events it creates a new calendar, how to merge into default calendar?

Hi
The calendar invites are created dynamically, If the calendar has one event it works fine and merges it to default calendar but if the calendar had two events its creating a new calendar.
How to merge it into default calendar?