sausagetaste / io_scene_dalbaragi

Blender addon to export 3D model file for Dalbaragi engine.

io_scene_dalbaragi

Blender addons for Dalbaragi engine.

io_scene_dalbaragi's Issues

Better to implement a dedicated class for Python modules

io_scene_dalbaragi/cpp/b3dsung.cpp

Line 689 in 768b839

PyObject* const modu = PyModule_Create(&module_def);

Implement `out_ptr` here

io_scene_dalbaragi/cpp/b3dsung.cpp

Line 106 in 768b839

class PythonObject {

Like following.

class PythonObject {
    ...

    PyObject** out_ptr() {
        return &obj_;
    }

    ...
};

Must call `Py_INCREF` on `bpy_mesh_ptr`

io_scene_dalbaragi/cpp/b3dsung.cpp

Line 469 in 768b839

auto bpy_mesh = ::PythonObject{bpy_mesh_ptr, true};

The bpy_mesh_ptr is borrowed reference, and it may be destroyed while std::async is using it.
Calling Py_INCREF(bpy_mesh_ptr) before the line will fix the problem.

On the other hand, Py_DECREF is not necessary.
Note the second arguemnt true in the ::PythonObject constructor.

Crashes when exporting an model with no animation upon removing useless joints.

If a model has a armature but no animations, the exporter will fail to optimize out useless joints.
Saying something like this:

Traceback (most recent call last):
  File "C:\Users\woos8\AppData\Roaming\Blender Foundation\Blender\2.81\scripts\addons\io_scene_dalbaragi\__init__.py", line 529, in execute
    model = ModelBuilder(self.optionBool_removeUselessJoints)
  File "C:\Users\woos8\AppData\Roaming\Blender Foundation\Blender\2.81\scripts\addons\io_scene_dalbaragi\__init__.py", line 359, in __init__
    jointIndexMap = self.__skeleton.removeJoints(uselesses)
  File "C:\Users\woos8\AppData\Roaming\Blender Foundation\Blender\2.81\scripts\addons\io_scene_dalbaragi\datastruct.py", line 392, in removeJoints
    if joint.m_name in jointNames:
TypeError: argument of type 'NoneType' is not iterable

Always use primitive type keys to refer to blender objects

For instance, store mesh name as std::string instead of mesh object pointer.