satom99 / phx_raws Goto Github PK

Hi first of all thanks for creating this, I was quite shocked to see that WebSockets are not supported in Phoenix and relieved to find this :D

That said for those of us less versed in Phoenix it would be really awesome to add a line or two how to add this to the routes.

Specifically things like def handle(:text, message, _state) do imply it is a textural format, where websockets are a binary stream and it should probably be exposed as such. Probably just :input or something would be more properly descriptive of the message.

As well as returning just a state as a return option from handle is ambiguous with the other options and should be properly tagged, probably by following the GenServer standard style for not returning something, same with the other formats, they should probably all follow the style of GenServer's.