sap-samples / cloud-commerce-sample-setup Goto Github PK

In addition to utilizing SAP Help portal for documentation of the manifest.json file used for deployments, create a publicly-accessible JSON Schema to reduce errors in the creation of builds for SAP Commerce.

What a `manifest.json` JSON Schema support in SAP Commerce/Cloud Portal Looks Like

Freely accessible
Abides by JSON Schema

Support in the manifest.json to reference the schema

{
 "$schema": "http://example.com/sap-commerce-cloud-schema",
 "commerceSuiteVersion": "1905",
 "extensions": [
     "modeltacceleratorservices"
 ],

Why a JSON Schema for `manifest.json`?

Reduces build errors from incorrectly formatted manifest.json
Understand value "defaults"
Autocomplete/Correction available where JSON Schema is supported (VSCode)

[rl-assigned_teams-2] Violation against OSS Rules of Play

A violation against the OSS Rules of Play has been detected.

Rule ID: rl-assigned_teams-2
Explanation: Does it have an admin team on GitHub? No

Find more information at: https://sap.github.io/fosstars-rating-core/oss_rules_of_play_rating.html

Cloud Build is failed with missing promotionenginesamplesaddon/project.properties.template

In SAP Commerce Cloud, simply trigger a new build on branch 2105-spartacus.

The build is failed with this error:
` [echo] Generate project.properties file from template /opt/workspace/build/commerce-suite/hybris/bin/modules/promotion-engine/promotionenginesamplesaddon/project.properties.template

BUILD FAILED
/opt/workspace/build/commerce-suite/hybris/bin/modules/core-accelerator/addonsupport/resources/addonsupport/ant/acc-ant-addons.xml:730: The following error occurred while executing this line:
/opt/workspace/build/commerce-suite/hybris/bin/modules/core-accelerator/addonsupport/resources/addonsupport/ant/acc-ant-addons.xml:644: The following error occurred while executing this line:
/opt/workspace/build/commerce-suite/hybris/bin/modules/core-accelerator/addonsupport/resources/addonsupport/ant/acc-ant-addons.xml:648: The following error occurred while executing this line:
/opt/workspace/build/commerce-suite/hybris/bin/modules/core-accelerator/addonsupport/resources/addonsupport/ant/acc-ant-addons.xml:321: project.properties.template file doesn't exist : /opt/workspace/build/commerce-suite/hybris/bin/modules/promotion-engine/promotionenginesamplesaddon/project.properties.template

Total time: 3 seconds
Overall progress: 35
2021-09-20T02:32:44.216Z Task task ':buildCoreCommerce' finished

Task :buildCoreCommerce FAILED
:buildCoreCommerce (Thread[Daemon worker,5,main]) completed. Took 9.58 secs.

FAILURE: Build failed with an exception.
`

jalo classes in src should not be ignored

The .gitignore file should not ignore jalo classes in src as historically these classes were used to implement custom before Service Layer was introduced.

Besides this can break the compilation when switching to branches that don't have the item type due to the top level Jalo classes missing the generated Jalo super classes

[rl-vulnerability_alerts-1] Violation against OSS Rules of Play

The OSPO bot created this issue by mistake - It did not have enough priviledge to check the vulnerability alerts, So I am closing this issue now. Sorry for any inconvenience.

[rl-reuse_tool-4] Violation against OSS Rules of Play

A violation against the OSS Rules of Play has been detected.

Rule ID: rl-reuse_tool-4
Explanation: Is it compliant with REUSE rules? No

Find more information at: https://sap.github.io/fosstars-rating-core/oss_rules_of_play_rating.html

import { NgModule } from '@angular/core';
import { BrowserModule } from '@angular/platform-browser';
import { ConfigModule } from '@spartacus/core';
import { translationChunksConfig, translations } from '@spartacus/assets';
import { TmaB2cStorefrontModule, tmaTranslations } from '@spartacus/tua-spa';
import { environment } from 'src/environments/environment';


@NgModule({
  declarations: [],
  imports: [
        TmaB2cStorefrontModule.withConfig({
      backend: {
        tmf: {
          baseUrl: environment.baseUrl,
          prefix: '/b2ctelcotmfwebservices',
          version: '/v2',
          endpoints: {
            getProduct: {
            baseUrl: environment.baseUrl,
            prefix: '/b2ctelcotmfwebservices',
            version: '/v3',
            endpoint: '/product/${id}'
            },
            getProductOffering: {
            baseUrl: environment.baseUrl,
            prefix: '/b2ctelcotmfwebservices',
            version: '/v3',
            endpoint: '/productOffering/${id}'
            }
          }
        },
        occ: {
          baseUrl: environment.baseUrl,
          prefix: '/occ/v2/',
        },
        tmf_appointment: {
          baseUrl: environment.baseUrl,
          prefix: '/tmf-api',
        },
        tmf_resource_pool_management: {
          baseUrl: environment.baseUrl,
          prefix: '/tmf-api',
        },
        premiseLookup: {
          baseUrl: environment.baseUrl,
          prefix: '/premise/v1/',
        }
      },
      context: {
        urlParameters: ['baseSite', 'language', 'currency'],
        baseSite: ['telcospa']
      },
      i18n: {
        resources: translations,
        chunks: translationChunksConfig,
        fallbackLang: 'en',
      },
      features: {
        level: '3.0'
      },
      journeyChecklist: {
        journeyChecklistSteps: ['APPOINTMENT', 'MSISDN', 'INSTALLATION_ADDRESS'],
        msisdn_reservation: {
          msisdn_qty: 1,
          msisdn_capacity_amount_demand: 1,
          msisdn_applied_capacity_amount: 5,
          applied_capacity_amount_for_msisdn_reservation: 1,
        },
        appointment: {
          requested_number_of_timeslots: 5,
          end_date_of_timeslots: 3,
        }
      },
      deliveryMode: {
        default_delivery_mode: 'not-applicable'
      }
    })
  ],
  exports: [TmaB2cStorefrontModule]
})
export class SpartacusModule { }

add package.json

"chart.js": "^2.9.3",
"ng2-charts": "^2.3.2",
"ngx-spinner": "^9.0.1"

Compiling ng2-charts : es2015 as esm2015
/cloud-commerce-sample-setup-2105-spartacus/js-storefront/spartacusstore/node_modules/@angular/compiler-cli/ngcc/src/entry_point_finder/targeted_entry_point_finder.js:40
                throw new Error("The target entry-point \"" + invalidTarget.entryPoint.name + "\" has missing dependencies:\n" +
                ^

Error: The target entry-point "@spartacus/tua-spa" has missing dependencies:
 - @spartacus/storefront/feature-toggles

    at TargetedEntryPointFinder.findEntryPoints (/cloud-commerce-sample-setup-2105-spartacus/js-storefront/spartacusstore/node_modules/@angular/compiler-cli/ngcc/src/entry_point_finder/targeted_entry_point_finder.js:40:23)
    at /cloud-commerce-sample-setup-2105-spartacus/js-storefront/spartacusstore/node_modules/@angular/compiler-cli/ngcc/src/execution/analyze_entry_points.js:29:41
    at SingleProcessExecutorSync.SingleProcessorExecutorBase.doExecute (/cloud-commerce-sample-setup-2105-spartacus/js-storefront/spartacusstore/node_modules/@angular/compiler-cli/ngcc/src/execution/single_process_executor.js:28:29)
    at /cloud-commerce-sample-setup-2105-spartacus/js-storefront/spartacusstore/node_modules/@angular/compiler-cli/ngcc/src/execution/single_process_executor.js:57:59
    at SyncLocker.lock (/cloud-commerce-sample-setup-2105-spartacus/js-storefront/spartacusstore/node_modules/@angular/compiler-cli/ngcc/src/locking/sync_locker.js:34:24)
    at SingleProcessExecutorSync.execute (/cloud-commerce-sample-setup-2105-spartacus/js-storefront/spartacusstore/node_modules/@angular/compiler-cli/ngcc/src/execution/single_process_executor.js:57:27)
    at Object.mainNgcc (/cloud-commerce-sample-setup-2105-spartacus/js-storefront/spartacusstore/node_modules/@angular/compiler-cli/ngcc/src/main.js:74:25)

[rl-assigned_teams-3] Violation against OSS Rules of Play

A violation against the OSS Rules of Play has been detected.

Rule ID: rl-assigned_teams-3
Explanation: Does it have enough admins on GitHub? No

Find more information at: https://sap.github.io/fosstars-rating-core/oss_rules_of_play_rating.html

Missing extensions in localextensions.xml in 2005-spartacus branch

<extension name='permissionswebservices' />

<extension name='acceleratorbackoffice' />
<extension name='acceleratorcms' />
<extension name='acceleratorfacades' />
<extension name='acceleratorocc' />
<extension name='acceleratorservices' />
<extension name='acceleratorstorefrontcommons' />

ATP Sample data should be reviewed to explicitly attach BaseStore

This ATP doesn't work for B2B powertools and SAP Commerce 2211.10

# Updates the OMS ATP default formula for stock calculation to avoid products with placed orders to go out of stock
INSERT_UPDATE AtpFormula;code[unique=true];availability;allocation;cancellation;increase;reserved;shrinkage;wastage;returned
;Default_Formula;true;false;false;true;false;true;true;true

No matching version found for @spartacus/asm@~6.0.0.

Describe the bug
When I call npm install I receive the following error:

npm ERR! code ETARGET npm ERR! notarget No matching version found for @spartacus/asm@~6.0.0.

Tell us the version of Spartacus

branch check: 2211-4-spartacus-6-0-0

To Reproduce
Steps to reproduce the behavior:

clone the project (branch 2211-4-spartacus-6-0-0).
CD project.
Run npm install or npm update.
See error

Expected behavior
The dependencies should be installed and node_modules folder should appear.

[rl-reuse_tool-2] Violation against OSS Rules of Play

A violation against the OSS Rules of Play has been detected.

Rule ID: rl-reuse_tool-2
Explanation: Does it have LICENSES directory with licenses? No

Find more information at: https://sap.github.io/fosstars-rating-core/oss_rules_of_play_rating.html

sap-samples / cloud-commerce-sample-setup Goto Github PK

cloud-commerce-sample-setup's Issues

What a manifest.json JSON Schema support in SAP Commerce/Cloud Portal Looks Like

Why a JSON Schema for manifest.json?

Recommend Projects

Recommend Topics

Recommend Org

What a `manifest.json` JSON Schema support in SAP Commerce/Cloud Portal Looks Like

Why a JSON Schema for `manifest.json`?