samsunginternet / snapwat Goto Github PK

It doesn't fill the available space. First impression: it seems like the LoadImage lib doesn't take into account the photo's orientation while determining the max dimensions?

Add drag handles you can use without a multi-touch device

Weird one...

Long-tap to save works fine after you choose the camera feed (getUserMedia) option and snap a still from that:

But if you choose the input type="file" option, the save image option is disabled!

I've checked the HTML for the image and it looks exactly the same. It works fine in desktop Chrome...

There are only sympols instead of emoticons

I broke this when I switched out the WebRTC adapter for a smaller shim

To allow you to press Send while offline and have it work when the connection comes back

A bit further down the line, I'd like to add this so, for example, you can get notified when there's new themes/emojis/filters to try

Should be able to use the rollup build to generate this? Could maybe ask Rich Harris how they did it for RioRun... :)

The way the drawing data is saved is not very efficient and I'm wiping and redrawing the whole canvas when you move/resize an emoji.

Unfortunately the long-tap to save the image is disabled in standalone app mode in Samsung Internet, i.e. when you launch it from the home screen icon.

See: https://developers.google.com/web/fundamentals/native-hardware/capturing-images/

Video is squashed at different browser sizes and it makes @adaroseedwards scream!

When you change the drawing colour, then do something that makes the scene get redrawn, e.g. moving an emoji, all the previous drawings will be redrawn in the new colour

On Samsung Internet on mobile, if I select a local image with the file input, it loads in a clearly degraded resolution.

E.g. Original file (Well, Github may have processed the image when uploaded here, but it gives the idea):

Screenshot of how it looks once loaded in Snapwat:

I'm taking a look at the code in src/pages/home.js that uses JavaScriptLoadImage...

This used to work... :-/

Tested in Chrome on desktop:

On a patchy network, it could take a long time for the fetch to fail and reach the catch. I could introduce sw-toolbox or possibly introduce a similar timeout feature.

Using transparent color png overlying as camera filters like instagram.

Lost this feature when I moved to emojis as text - need to reimplement

See: https://developers.google.com/web/updates/2016/10/navigator-share

As @diekus shared, it's too easy to accidentally place extra emojis when trying to e.g. resize an existing one.

This could be resolved by requiring that you specifically select an emoji, then tap, each time (subsequent taps will only be used for selection / moving / resizing).

Is there any possibilities to run video over webcam stream. that would be awesome.

The SVGs looked better than the emoji characters - especially when resized larger. I think it'll be worth re-introducing them even though it's more images to download. I'll just have a small set.

I just saw Modernizr feature detects emojis:

https://modernizr.com/docs

http://gorigins.com/posting-a-canvas-image-to-facebook-and-twitter/

When you tap, currently it will select the first hit