Coder Social home page Coder Social logo

equation-solver's People

Contributors

samshal avatar

Stargazers

 avatar

Watchers

 avatar  avatar  avatar

equation-solver's Issues

[fixed] check overflow of string

Original code:

if (strstr("eE", $number[$i+1]))

with input of b coef +8x for example.

The if structure alway returns true and enter the if block.

So, the code should be added checking condition if $i is bigger than the string length.

if (strstr("eE", $number[$i+1]) && $i+1 < $j) // check overflow of number string

Fixed: Code not run in new php version

For quick sample data, the code cannot run, returns empty:

$equation = "xe2 + 5x - 20 = 8x + 20";

Current code:

	foreach ($a as $elem)
	{
		$acoeff += $elem;
	}    

	foreach ($b as $elem)
	{
		$bcoeff += $elem;
	}    

	foreach ($c as $elem)
	{
		$ccoeff += $elem;
	}

Fixed by converting empty data to number:

	foreach ($a as $elem)
	{
		$acoeff += (double)$elem;
	}    

	foreach ($b as $elem)
	{
		$bcoeff += (double)$elem;
	}    

	foreach ($c as $elem)
	{
		$ccoeff += (double)$elem;
	}

Fails to solve equations where right hand side starts with -

Can be fixed by changing the logic to look like this in both places:

        $lhs = explode("=", $this->equation)[0];
        $lhsSub = substr($lhs, 0, 1);
		if (is_numeric($lhsSub))
		{
			$lhs = "+".$lhs;
		}
		else if ($lhsSub != '+' && $lhsSub != '-')
		{
			$lhs = "+1".$lhs;
		}
		for ($i = 0, $j = strlen($lhs); $i < $j; $i++)
		{
			if (strstr("+-", $lhs[$i]))
			{
				//$pos = strpos($lhs, $lhs[$i]);
				//echo $i."<br/>";
				$positions[] = $i;
			}
		}

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.