Coder Social home page Coder Social logo

Comments (3)

sampsyo avatar sampsyo commented on June 15, 2024

Thanks for reporting! Indeed; here's where those main arguments are handled:

bril/bril-ts/brili.ts

Lines 803 to 812 in b37c9ee

switch (type) {
case "int":
let n: bigint = BigInt(parseInt(args[i]));
newEnv.set(expected[i].name, n as Value);
break;
case "bool":
let b: boolean = parseBool(args[i]);
newEnv.set(expected[i].name, b as Value);
break;
}

As you can see, it only supports int and bool. Two observations:

  • We should add a float case using parseFloat.
  • The switch also lacks a default case; it would be better to report an error there indicating that the type is unsupported for CLI arguments.

from bril.

czarku7 avatar czarku7 commented on June 15, 2024

7

from bril.

sampsyo avatar sampsyo commented on June 15, 2024

Fixed in #182.

from bril.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.