saltyfacu / ape-tax Goto Github PK

Add the doc of the API to the README file. Reference: #100 (comment)

e.g. https://ape.tax/purpletwister

The vaults there don't show any related data...

I believe the vault is not setup properly with https://www.coingecko.com/en/coins/spookyswap

What is your proposal 🚀

In VaultDetails.tsx in the Deposit Limit: section we have a condition that either shows - when the vault depositLimit is 0 or it shows the vault limit rounded to 2 decimal places.

In the specific case where a vault limit is the largest possible unsigned number (MAX_UINT_256) deposit limit of the vault is show as below, which can be improved.

We should adjust this condition to show Deposit Limit: ∞ in the case the vault returns a limit greater than or equal to MAX_UINT-256 as seen below.

What does this solve ? 🛠

Better overall user experience for this specific case

More 🔎

When you think you have the right condition you can test by declaring a variable like seen below and using it instead of the actual vaultData.depositLimit.raw value to see if you UI shows properly.

Zap in is allowing the user to zap 0 funds, it shouldn't alow it.

Using https://github.com/yearn/yearn-meta show a description of each strategy

What is your proposal 🚀

We have a local versions of useWindowInFocus hook but there is also an equivalent hook in web-lib.

ours: https://github.com/saltyfacu/ape-tax/blob/master/hook/useWindowInFocus.tsx
web-lib's: https://github.com/yearn/web-lib/blob/main/packages/web-lib/hooks/useWindowInFocus.tsx

Seems like we can update local imports to use web-lib instead, then remove the local hook from the repo

What does this solve ? 🛠

Trade off of reducing local code, but increasing dependence on web-lib. Should be fine to do this.

Overview

Total AUM and APR are not shown correctly in vaults v3. This is what's shown on the website, but is incorrect:

Total AUM: $0.00
Gross APR (last week): Infinity%
Gross APR (last month): Infinity%
Gross APR (inception): 100000000000000000000.0000%

Reproduce

Go to: https://ape.tax/pearl-v3-usdc
Connect a wallet
Check the data above

Thoughts

No response

What is your proposal 🚀

Currently we have a wagmiConfig.ts file (utils/wagmiConfig.ts) the file imports chain details then passes them to the configureChains() function which tells our app which chains ape tax should support.

We should follow the good example set by the big brains at SmolDapp! This can be done by separating out all the specific chain details objects into their own file probably called wagmiChains.ts then exporting them similar to what is shown here:

https://github.com/SmolDapp/smoldapp/blob/main/utils/wagmiChains.ts

What does this solve ? 🛠

Increases ease of reading and understanding the config file by moving chain specific details to a new file that only contains these chain specific details.

More 🔎

Make this adjustment on feat/v3-new branch please

There will be no visual change to the app since this is just a change to overall organization / structure.

What is your proposal 🚀

Add support for v3 Ape.Tax test vaults

What does this solve ? 🛠

A clear and concise description about why this is a nice to have.

More 🔎

N/A

Description:

This strategy links https://ape.tax/fantombaby with https://ape.tax/fantomsfury
A ProviderStrategy in each vault will provided a usd fixed amount (5k usd) to a Joint contract which will provide liquidity to ICE/WFTM and farm ICE tokens. Once enough profit is made, the strategy will be liquidated and funds return.

Commit (hash): poolpitako/joint-strategy@7834b51

Tag:

Repo: https://github.com/poolpitako/joint-strategy

Scope: (List link to files)

• Joint.sol
• ProviderStrategy.sol

Additional References or Repo (Link to underlying protocols or relevant documents):

Deployed Contract (etherscan link):

Review Ongoing By:

• @akshaynexus
• @TheRyanMiller

Review Completed By:

• @akshaynexus
• @TheRyanMiller

On the Ape API, we are using Alchemy to get our vaults data. If the requester wants to, we should provide a way to override our rate-limited key with it's custom key. This will limit third party limitation due to our cache stuff

Do we want to add strategies to the API? Is it worth it?

When approving the vault, the approve button stays on and never enables deposits.

Vault: https://ape.tax/fantombaby

I noticed that our Deploy your own vault button doesn't look quite as nice on small screens.

I think this should be done similar to how we change the title of our home page by showing one option on larger screens, then use media queries to show another option on small screens. I've included below and idea of what I think the final result should look like.

When the RPC that the user has for Fantom is not compatible with our APY calculations, suggest to change it to rpc.ftm.tools.

When debugging other issues I noticed that some of our visual elements overlap on mid-sized screens. Should be an easy adjustment to media queries. Please look in the index.tsx file to find this title and make the media query adjustments.

I figured it out

When I open ape.tax using Arbitrum (an unsupported chain id), the site hangs saying "Loadgin Ex2". The console shows:

Uncaught (in promise) e: Unsupported chain id: 42161. Supported chain ids are: 1,56,137,250,1337.
at https://ape.tax/_next/static/chunks/pages/_app-778eacfcaeaafa42e331.js:1:179453

Expected behavior
Show something saying: change network.

Description:

Based on the MasterChef strategy from @Grandthrax and my own mir-ust strategy, it's extending the strategy to support LP tokens that needs an additional swap, adding liquidity to the liquidity pool, and depositing back into Masterchef.
The plan is to farm pancakeswap and ramenswap.

Commit (hash): 56331e3e686b468b1ff5a3c0205e53d347d018b7

Tag:

Repo: https://github.com/steffenix/yearnv2-masterchef-LP-token-generic

Scope: (List link to files)

• Strategy.sol

Additional References or Repo (Link to underlying protocols or relevant documents):

Deployed Contract (etherscan link):

https://github.com/Grandthrax/yearnv2-masterchef-generic
https://github.com/steffenix/yearn-strategy-mir-ust

Review Ongoing By:

• Dev 1
• Dev 2

Review Completed By:

• Dev 1
• Dev 2

Currently you can see production vaults included in the Eth tvl number, but it would be nice if this was just the sum of tvl in experimental/non-prod vaults. Maybe a fix could be to make two page views one with vaults moved to prod, one with ape vaults and have tvl on both, or just sum tvl from non-prod vaults.

On the Ape API, the data are cached for 10 minutes.
We should add an optional param to force the revalidation when the user asks for it.
To avoid abuse on this, maybe we should build it with the requester AlchemyKey (so it's the requester usage and not "we")

Description: This strategy stakes 3EPS in the staking pool.On harvest it gets the rewards, exits early, swaps EPS to BUSD then adds liquidity to 3EPS with single sided deposit with BUSD.

Commit (hash): a86197d2e4ec02fc57283b659dfc04b578b001af

Tag: master

Repo: https://github.com/akshaynexus/yearnv2-3poolellipsis-strat/

Scope: (List link to files)

• https://github.com/akshaynexus/yearnv2-3poolellipsis-strat/blob/main/contracts/Strategy.sol

Additional References or Repo (Link to underlying protocols or relevant documents):

Deployed Contract (etherscan link):

Review Ongoing By:

• @poolpitako
• @Grandthrax

Review Completed By:

• @poolpitako
• @Grandthrax

It would be useful for discovery to have a switcher or a dropdown which allows connecting to chains where ape.tax is available.

Metamask has an RPC method to add/switch chains
https://docs.metamask.io/guide/rpc-api.html#wallet-addethereumchain

The needed metadata can be obtained here
https://chainid.network/chains.json

As discussed @saltyfacu
DAI 0.4.5 vault created here:
https://optimistic.etherscan.io/address/0x780210e8826064b94e71f5b7bbb73d92637c48d6

Live vault used to have a custom UI with more functionality. I will elaborate later. Just want to track this now.

What is your proposal 🚀

Use WAGMI

What does this solve ? 🛠

A clear and concise description about why this is a nice to have.

More 🔎

N/A