saltstack-formulas / chrony-formula

Salt Stack formula to manage chrony

chrony-formula

Formula to set up and configure chrony

Table of Contents

General notes

See the full SaltStack Formulas installation and usage instructions.

If you are interested in writing or contributing to formulas, please pay attention to the Writing Formula Section.

If you want to use this formula, please pay attention to the FORMULA file and/or git tag, which contains the currently released version. This formula is versioned according to Semantic Versioning.

See Formula Versioning Section for more details.

Contributing to this repo

Commit message formatting is significant!!

Please see How to contribute for more details.

Available states

chrony

Meta-state (This is a state that includes other states).

This installs the chrony package, manages the chrony configuration file and then starts the associated chrony service.

chrony.package

This state will install the chrony package only.

chrony.config

This state will configure the chrony service and has a dependency on chrony.install via include list.

chrony.service

This state will start the chrony service and has a dependency on chrony.config via include list.

chrony.clean

Meta-state (This is a state that includes other states).

this state will undo everything performed in the chrony meta-state in reverse order, i.e. stops the service, removes the configuration file and then uninstalls the package.

chrony.service.clean

This state will stop the chrony service and disable it at boot time.

chrony.config.clean

This state will remove the configuration of the chrony service and has a dependency on chrony.service.clean via include list.

chrony.package.clean

This state will remove the chrony package and has a depency on chrony.config.clean via include list.

chrony-formula's Issues

Remove extra config from pillar.example

Comment on Pull request #5 from @aboe76

"can you please update the pillar.example. and remove extra config part.."

I verified #5 against pillar.example below because defaults.sls now has good defaults instead.

pillar.example

chrony:
  config:

@aboe76 Should pillar.example look like this? If yes I'll raise PR now.

allow override a single value from the "otherparams" list

When we need to add a new param or to override a value from the default params in the "otherparams" list, we have to override the whole "otherparams" list which is not great as I still want to keep the default Debian values for example.

@mraymond77: do you know any workaround?

[FEATURE] License

Quite simply, the project lacks a license. It would be great to have a clear license assigned.
@mraymond77 appears to be the original creator and has no license publicly assigned in the original repo.

small issue on systemd machines

Add option for systemd machines to set:

timedatectl set-ntp true

see:
https://www.lisenet.com/2016/time-synchronisation-with-chrony-on-rhel-7/

TemplateNotFound due to slspath problem

Formula failed on Centos7 due to problem with #8 because slspath+ cannot be rendered. Probably we need slspath + instead (i.e. white spaces).

    Data failed to compile:
----------
    Rendering SLS 'base:chrony.init' failed: Jinja error: chrony/init/map.jinja
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/salt/utils/templates.py", line 413, in render_jinja_tmpl
    output = template.render(**decoded_context)
  File "/usr/lib/python2.7/site-packages/jinja2/environment.py", line 969, in render
    return self.environment.handle_exception(exc_info, True)
  File "/usr/lib/python2.7/site-packages/jinja2/environment.py", line 742, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "<template>", line 1, in top-level template code
  File "/usr/lib/python2.7/site-packages/salt/utils/jinja.py", line 145, in get_source
    raise TemplateNotFound(template)
TemplateNotFound: chrony/init/map.jinja

; line 1

---
{% from slspath+"/map.jinja" import chrony with context %}    <======================

server and pool options should be set separate.

It would be nice to be able to set different options per server:

server ntp.time.nl iburst prefer
server ntp0.nl.net iburst
server ntp1.nl.net iburst
server ntp2.nl.net iburst

or

server ntp.time.nl iburst prefer
pool nl.pool.ntp.org iburst maxsources 3

chrony.conf is not affected by osmap.yaml

When I add a desired IP address to the osmap.yaml, it does not add the server IP to /etc/chrony/chrony.conf