salt-v / saltychat-altv

AltV implementation of Salty Chat (TeamSpeak 3 based Voice Plugin) using Typescript & C#

If you don't know how to work with C# or TypeScript, use the pre-built resource which is an ready2go pack with config files.

Read me before use

Read the license before using this script.
Additional limitations:

• You're not allowed to monetize this script (by selling this script, an gamemode related to this script or other ways)
• ValeaRP is granted to use this script. Support for ValeaRP is only guaranteed as long as an unmodified implementation of the script is used and no customizations (except editing the configuration files according to the wiki) have been performed.

This plugin is not tested on high player counts.
Although it's designed to be plug & play, there may be issues with some functions of the script.
Don't use this if you don't know what you're doing.

Salty Chat for alt:V

An example implementation of Salty Chat for alt:V.

You can report bugs or make sugguestions via issues, or contribute via pull requests - I appreciate any contribution.
Join the Salty Chat Discord and start with Salty Chat!

Current supported plugin version

see Versioning and Update Branches

• SaltyChat 1.3.3 Stable
• SaltyChat 2.0.0 Stable
• SaltyChat 2.3.6+ Stable
• SaltyChat 3.X.X Stable

Wiki

For more information and a getting started guide check out the wiki.

Support

There won't be any private support for this script.
If you experience any bugs using this script, feel free to open up an issue. Same applies to feature requests.
If your issue belongs to the SaltyChat plugin itself, ask in the appropriate channels on the Salty Chat Discord.**

saltychat-altv's Issues

TS3 Plugin Version 3.X.X Problem

Since the plugin Update User cant Talk / no voice Aktivation in the Ingame Voice Channel.

Sideeffects: Swiss Channel works as usual.

Problem Can be validated with the Plugin Verison 2.3.6

Radio doesn't work well

SaltyChat: 2.2.2

No Radio activate sound and no TeamSpeak response.
Other Users cannot hear me.

Phone not hanging up

Version
3.0.5

Describe the bug
Call is not ending after hanging up.

Usage of the code
We use the newest version of SaltyChat.

To Reproduce
Steps to reproduce the behavior:

1. Call any user
2. Hang up
3. You can still hear each other.

Expected behavior
The other player cannot be heard anymore.

Altv neuste Version

Moin erst mal geile arbeit die sie machen

So nun zum Problem wen ich saltychat Aufenthalt server update startet der server nicht mehr und es kommt der fehler

Unbehandelte Ausnahme erhalten von: AltV.Net.Exceptions.IllegalThreadException: CheckIfEntityExists from AltV.Net.Elements.Entities.Player hat im falschen Thread mit Name und ID 29 aufgerufen

at AltV.Net.Elements.Entities.BaseObject.CheckIfCallIsValid(String callerName)

bei AltV.Net.Elements.Entities.Entity.CheckIfEntityExists()

bei AltV.Net.Elements.Entities.Player.get_Position()

at SaltyChat.Server.VoiceManager.OnServerEnablePlayer(IPlayer player, Int32 charId) in C:\Users\Administrator\Desktop\Infinity-city-V3 1\Infinity-city-V3 1\Mappe\Altv-Roleplay\SaltyServer\VoiceManager.cs :Zeile 216

at System.Threading.Tasks.Task.<>c.b__140_1(Objektstatus)

at System.Threading.QueueUserWorkItemCallback.<>c.<.cctor>b__6_0(QueueUserWorkItemCallback quwi)

at System.Threading.ExecutionContext.RunForThreadPoolUnsafe[TState](ExecutionContext ExecutionContext, Action`1 Callback, TState& Zustand)

bei System.Threading.QueueUserWorkItemCallback.Execute()

bei System.Threading.ThreadPoolWorkQueue.Dispatch()
[03:30:12] < ==== UNHANDLED AUSNAHME ==== >

Unbehandelte Ausnahme erhalten von: AltV.Net.Exceptions.IllegalThreadException: CheckIfEntityExists from AltV.Net.Elements.Entities.Player hat im falschen Thread mit Name und ID 29 aufgerufen

at AltV.Net.Elements.Entities.BaseObject.CheckIfCallIsValid(String callerName)

bei AltV.Net.Elements.Entities.Entity.CheckIfEntityExists()

bei AltV.Net.Elements.Entities.Player.get_Position()

at SaltyChat.Server.VoiceManager.OnServerEnablePlayer(IPlayer player, Int32 charId) in C:\Users\Administrator\Desktop\Infinity-city-V3 1\Infinity-city-V3 1\Mappe\Altv-Roleplay\SaltyServer\VoiceManager.cs :Zeile 216

at System.Threading.Tasks.Task.<>c.b__140_1(Objektstatus)

at System.Threading.QueueUserWorkItemCallback.<>c.<.cctor>b__6_0(QueueUserWorkItemCallback quwi)

at System.Threading.ExecutionContext.RunForThreadPoolUnsafe[TState](ExecutionContext ExecutionContext, Action`1 Callback, TState& Zustand)

bei System.Threading.QueueUserWorkItemCallback.Execute()

bei System.Threading.ThreadPoolWorkQueue.Dispatch()
[03:30:12] < ==== UNHANDLED AUSNAHME ==== >

Unbehandelte Ausnahme erhalten von: AltV.Net.Exceptions.IllegalThreadException: CheckIfEntityExists from AltV.Net.Elements.Entities.Player hat im falschen Thread mit Name und ID 29 aufgerufen

at AltV.Net.Elements.Entities.BaseObject.CheckIfCallIsValid(String callerName)

bei AltV.Net.Elements.Entities.Entity.CheckIfEntityExists()

bei AltV.Net.Elements.Entities.Player.get_Position()

at SaltyChat.Server.VoiceManager.OnServerEnablePlayer(IPlayer player, Int32 charId) in C:\Users\Administrator\Desktop\Infinity-city-V3 1\Infinity-city-V3 1\Mappe\Altv-Roleplay\SaltyServer\VoiceManager.cs :Zeile 216

at System.Threading.Tasks.Task.<>c.b__140_1(Objektstatus)

at System.Threading.QueueUserWorkItemCallback.<>c.<.cctor>b__6_0(QueueUserWorkItemCallback quwi)

at System.Threading.ExecutionContext.RunForThreadPoolUnsafe[TState](ExecutionContext ExecutionContext, Action`1 Callback, TState& Zustand)

bei System.Threading.QueueUserWorkItemCallback.Execute()

bei System.Threading.ThreadPoolWorkQueue.Dispatch()
[03:30:12] < ==== UNHANDLED AUSNAHME ==== >

Unbehandelte Ausnahme erhalten von: AltV.Net.Exceptions.IllegalThreadException: CheckIfEntityExists from AltV.Net.Elements.Entities.Player hat im falschen Thread mit Name und ID 29 aufgerufen

at AltV.Net.Elements.Entities.BaseObject.CheckIfCallIsValid(String callerName)

bei AltV.Net.Elements.Entities.Entity.CheckIfEntityExists()

bei AltV.Net.Elements.Entities.Player.get_Position()

at SaltyChat.Server.VoiceManager.OnServerEnablePlayer(IPlayer player, Int32 charId) in C:\Users\Administrator\Desktop\Infinity-city-V3 1\Infinity-city-V3 1\Mappe\Altv-Roleplay\SaltyServer\VoiceManager.cs :Zeile 216

at System.Threading.Tasks.Task.<>c.b__140_1(Objektstatus)

at System.Threading.QueueUserWorkItemCallback.<>c.<.cctor>b__6_0(QueueUserWorkItemCallback quwi)

at System.Threading.ExecutionContext.RunForThreadPoolUnsafe[TState](ExecutionContext ExecutionContext, Action`1 Callback, TState& Zustand)

bei System.Threading.QueueUserWorkItemCallback.Execute()

bei System.Threading.ThreadPoolWorkQueue.Dispatch()

Und wenn es dann doch mal geht geht der server aus wen zwei Spieler im voice sind und da kommt der fehler

den bekomme ich wen SaltyChat Started

WARNING: AltV.Net, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null is not optimized and might not provide best possible runtime performance.
WARNING: AltV.Net.Async, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null is not optimized and might not provide best possible runtime performance.

So lange ich alleine auf dem Server bin geht alles sobald einer drauf kommt geht nix mehr heißt der server geht aus ohne saltychat auf dem server aktive zu haben geht auch alles aber halt ohne voice

LG und tut mir leid wen es nicht hier her gehört

Players are not unmuted

Version
1.0.4

Describe the bug
Players are not unmuted to others (The other player hears the person). This phenomenon occurs randomly and can only be reproduced by chance.

Usage of the code
Just alt.emit("SaltyChat:EnablePlayer", player)

To Reproduce
Steps to reproduce the behavior:

1. Just try

Expected behavior
You should be able to hear other players

Whisper Problem

Version
3.0.5

Describe the bug
Normal talking seems to work through Whisper as well. If you talk to someone, it opens the Whisper history in TeamSpeak. If you turn off the power for Whisper in TeamSpeak, so that Whisper no longer works, you can no longer talk to the player opposite.

Usage of the code
/

To Reproduce
Steps to reproduce the behavior:

1. Implement 1.2.3 from Phill030 to the alt:V Server
2. Use Client Version 3.0.5
3. Speak with a other Player in your near
4. See error

Expected behavior
Normal Voice about TeamSpeak, not Whisper. Whisper only with Cellphone and Radio

Screenshots / Logs
https://media.discordapp.net/attachments/930510524016394331/930519386006110258/unknown.png

Additional context
/

After importing it, it doesnt work

Version
Newest version (Mar. 8)
Describe the bug
When i configured it, it showed me this error(Screenshots/Log) + It creates and invisible Windows ingame, when using it, wheter i load it at the top or at the bottom. + it shows in the console that it is loaded but i dont get moved or anything.

Usage of the code
I didnt use anything

To Reproduce
Steps to reproduce the behavior:

1. Import the resource
2. add it to the server.cfg
3. configure the json
4. load it
5. join server and teamspeak

Expected behavior
It should work by automatically joinen the channel, synchronizing the lips and allow to use Radio etc.

Screenshots / Logs

Additional context
My SaltyChat plugin version is 2.3/2.4 something around that

Microstutters

Hey,
a lot of other players, including me, are getting microstutters nearly all the time (about every 0.5 seconds or so) when playing with SaltyChat on altV. When there are only about 200 players or more it's starting to stutter.

In my Teamspeak Logs there is this error filling thousands of lines:
2021-09-04 20:06:36.672957|ERROR |Salty Chat |6 |Non-executable message: {"Command":6,"ServerUniqueIdentifier":"[CENSORED]","Parameter":{"IsMicrophoneMuted":true,"IsMicrophoneEnabled":false,"IsSoundMuted":false,"IsSoundEnabled":false}}

Maybe you can help fixing this issue.

Neuste Version und Server startet nicht richtig...

Servus,

gerade die neuste Version heruntergeladen und man wollte den Server Starten und sobald SaltyChat Client geladen wird stürzt der Server ab ohne Fehler oder etc.

Kommentiert man SaltyChat aus startet der Server ganz normal aber halt ohne Salty...

Unhandled exception. System.Reflection.TargetParameterCountException: Parameter count mismatch

Hi all,

i uploaded the content of resource folder.
But it wont start. It gives me that following Error.
Have you any Hints for that?

Files from: https://github.com/Salt-V/saltychat-altv

[csharp-module] Checking dependencies... this might take a few minutes...
Unhandled exception. System.Reflection.TargetParameterCountException: Parameter count mismatch.
at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
at AltV.Net.Host.Host.InitAltVAssembly(Assembly altVNetAssembly, LibArgs libArgs, AssemblyLoadContext resourceAssemblyLoadContext, Dictionary`2 cApiFuncTable, String resourceName)
at AltV.Net.Host.Host.ExecuteResource(IntPtr arg, Int32 argLength)
Server process exited with code 3762504530

Alt:V v15 Release - We need a update?

Alt:V Version 15 has been released - We need an update for SaltyClient. Are there any plans for such an update?

command 4: pong is throwing a client exception

Version
As of 14.06.2021, the prebuilt 1.07E2 was used and both configuration files were altered to fit my setup with ValeaRP script. (Quite problematic, sorry for that)

Describe the bug
After spawning, the teamspeak user gets moved to ingame channel, but no command 4: pong? is being answered.
Updating voice range is not possible via the key, which was working on a 2.2.5 serverside before.
After 6s, the teamspeak user is moved out of ingame-channel.

Usage of the code
The standard and well know parts of hud.js in ValeaRP. I can provide them, if needed.

To Reproduce
Steps to reproduce the behavior:
Get ValeaRP running, click "Letzte Position" to spawn and check the teamspeak log.

Expected behavior
Pong should be answered I guess?

Screenshots / Logs
Teamspeak + Salty extensive debug log:
ts3client_2021-06-14__03_51_28.096333.log
alt:V client log shows SaltyClient loaded succesfully and only one output line:
[04:38:46][Error] "{\"Error\":3,\"Message\":null,\"ServerIdentifier\":null}"

• SaltyChat in extensive logging mode done
• AltV client logs

Additional context
Is this behaviour the result of a non-implemented pong response server-side?

There is an File missing in the Resource folder

https://gyazo.com/743dc091c17dbece63146645dc6eddb7

The JavaScript version.

Add Ability to make Conference Calls

Currently it is not possible to add a third player to a phone call.

Great would be a function like "SaltyChat:AddToCall" to add another player to an existing call.

I've tried using the Secondary Radio for this, but it doesn't sound brilliantly.

Wrong Parameters on SaltyChat:RadioChanged Event

Version
Latest version 2.4.3

Describe the bug
When Radio Channel ist left and RadioChanged Event is triggered via onServerRadioLeaveChannel the parameters radioChannel and isPrimary are mixed up

Usage of the code
alt.on("SaltyChat:RadioChanged", (newRadioChannel, isPrimary) => {
alt.log("RadioChanged " + newRadioChannel + " " + isPrimary);
//--> Returns true/false and null instead of null and true/false
});

To Reproduce
Join Radio Channel and then leave it

Expected behavior
Event should be called right way round

Additional context
See Client/app.js 198 and 202.
Row 193 in onServerRadioSetChannel is correct.

Null Exception

Dear all, i receiving the following error when starting the SaltyChat ressource on my server:

[12:48:24] exception at event:SaltyChat:EnablePlayer:System.ArgumentNullException: Value cannot be null. (Parameter 'input')
at System.Text.RegularExpressions.ThrowHelper.ThrowArgumentNullException(ExceptionArgument arg)
at System.Text.RegularExpressions.Regex.Replace(String input, String replacement)
at System.Text.RegularExpressions.Regex.Replace(String input, String pattern, String replacement)
at SaltyChat.Server.VoiceManager.GetTeamSpeakName(IPlayer player) in C:\Users\Thomas\Desktop\altV-Script-master\Altv-Roleplay\SaltyServer\VoiceManager.cs:line 318
at SaltyChat.Server.VoiceManager.OnServerEnablePlayer(IPlayer player) in C:\Users\Thomas\Desktop\altV-Script-master\Altv-Roleplay\SaltyServer\VoiceManager.cs:line 143

Im using Teamspeak Version 3.13.6 and Alt V Version 14.64 - what can i do to fix?

Here are the mentioned lines in voice manager:

143: if (_voiceClients.ContainsKey(player)) _voiceClients[player] = voiceClient;
318: name = Regex.Replace(name, @"({serverid})", player.Id.ToString());

Thank you very much for your help