salimkanoun / moodle-mod_dicomviewer Goto Github PK
View Code? Open in Web Editor NEWLicense: GNU General Public License v3.0
License: GNU General Public License v3.0
Hello,thank for your help very much!
Can you tell me how to config and use moodle-mod_dicomviewer?Do I still need to install ohif viewer or stone viewer independently?
When including an external library in your plugin, you must include a thirdpartylibs.xml file that includes the name, location and license of the library.
More information on this is here:
https://docs.moodle.org/dev/Plugin_files#thirdpartylibs.xml
And here:
https://docs.moodle.org/dev/Plugin_with_third_party_libraries
One of the other advantages of using this is that Moodle's codechecker automatically ignores any files included in the location specificed in the thirdpartylibs.xml file.
Please note - this is a blocker for approval in the plugins db.
Moodle uses a privacy API for GDPR compliance to allow plugins to specify how they deal with user data. Your plugin doesn't appear to store any user data so you should be able to implement the simple null provider class.
Sites that use continuous integration processes will not be able to use your plugin because Moodle runs unit tests which check to see if all extra plugins include the privacy class.
More information on the privacy class is here:
https://docs.moodle.org/dev/Privacy_API
Note - this is not a blocker for approval in the plugins db.
looks like you've dropped in the backup api classes but forgot to add the restore part? - you need both! :-)
XMLDB has detected one TEXT/BINARY column (studyinstance) with some DEFAULT defined. This type of columns cannot have any default value. Please fix it in source (XML and/or upgrade script) to avoid this message to be displayed.
line 1696 of /lib/datalib.php: call to debugging()
line 352 of /lib/xmldb/xmldb_object.php: call to xmldb_debug()
line 261 of /lib/xmldb/xmldb_field.php: call to xmldb_object->debug()
line 359 of /lib/xmldb/xmldb_field.php: call to xmldb_field->setDefault()
line 543 of /lib/xmldb/xmldb_table.php: call to xmldb_field->arr2xmldb_field()
line 276 of /lib/xmldb/xmldb_structure.php: call to xmldb_table->arr2xmldb_table()
line 172 of /lib/xmldb/xmldb_file.php: call to xmldb_structure->arr2xmldb_structure()
line 153 of /lib/xmldb/xmldb_file.php: call to xmldb_file->arr2xmldb_structure()
line 349 of /lib/ddl/database_manager.php: call to xmldb_file->loadXMLStructure()
line 370 of /lib/ddl/database_manager.php: call to database_manager->load_xmldb_file()
line 847 of /lib/upgradelib.php: call to database_manager->install_from_xmldb_file()
line 582 of /lib/upgradelib.php: call to upgrade_plugins_modules()
line 1935 of /lib/upgradelib.php: call to upgrade_plugins()
line 721 of /admin/index.php: call to upgrade_noncore()
the stoneviewer versino seems semi recent, but the ohif one seems like it's been through quite a few updates since the version mentioned in your thirdpartylibs.xml file - it would be good for you to check to see if there are newer versions that fix any issues (particularly any that have security issues in their dependencies)
https://github.com/salimkanoun/moodle-mod_dicomviewer/blob/main/lang/en/dicomviewer.php#L51-L52
Those lines don't look like language strings - they should probably be stored somewhere else...
When putting something in the language file - think "how would someone translate this to German?" - if it's exactly the same, or is not a text string that is translatable it should probably be somewhere else. I suspect those 2 lines might need to be admin settings?
under admin> developer > debugging, please set the level to developer with display errors = on and test your plugin - it should not display any php or moodle debuging warnings. I spotted a few places in your code where I would expect to see warnings displayed - please note these are blockers for approval.
when you have resolved #6
Some of the tests run by the Moodle.org plugins db can be run via github actions on each commit in your github repo. Enabling this helps you to make sure future changes to your plugin will continue to follow the guidelines.
the short version - grab this file:
https://github.com/moodlehq/moodle-plugin-ci/blob/master/gha.dist.yml
rename it as ci.yml and put into the directory .github/workflows within tyour project eg:
https://github.com/danmarsden/moodle-mod_attendance/blob/main/.github/workflows/ci.yml
then on every commit you make to github it will fire off a request to run the tests and will give you traffic lights beside each commit and generate a report.
Docker Compose
=> Traefik
Reverse proxy vers moodle et vers orthanc
It looks like your plugin is missing the backup/restore api which is a requirement for activity plugins.
for more information see:
https://docs.moodle.org/dev/Backup_API
please note - this is a blocker for approval in the plugins db.
Documentation à faire
...
many organisations use git submodules/subtrees for installing plugins - for this reason your moodle plugin should sit at the root of the repository - you could put your docker stuff in a different repository and refer users to it in your readme.
mod mime est present dans bitnami moodle; peut ajouter le mjs mime dans un htaccess ou via les param serveur à evaluer
Please review our security guidelines here:
https://docs.moodle.org/dev/Security#Summary_of_the_guidelines
this is a blocker for approval in the plugins db.
https://docs.moodle.org/dev/Plugin_contribution_checklist#Namespace_collisions
form_config should really be namespaced rather than /form_config which could conflict with other core classes.
Thank you very much!
I had already install Orthanc dicom web server and moodle-mod_dicomviewer plugin,but I don't know how to config IIS web server to reverse proxy orthanc. I tried many times but failed, and nothing was displayed through the plugin,display 404 error。
Please try your best to help me!
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.