Comments (8)
Update: it looks like the name of the local branch doesn't matter, I changed my foo
branch to track github/master
and then yarn start
worked fine! 🤷🏻♂️
This is my setup:
manuel.jasso@manueljasso-ltm ~/dev/github/best/packages/lwc-example (foo)
$ git branch -vv
* foo 0c1ef01 [github/master] feat: rewrite of Agents, Hubs, Remotes and Algo (#217)
master 0c1ef01 [github/master] feat: rewrite of Agents, Hubs, Remotes and Algo (#217)
So best cli fails unless the current branch is tracking master
on the remote.
from best.
I can't seem to reproduce this, when I try to run the lwc-example benchmarks it works fine.
I tried both in master
and in a brand new branch that i just created, both worked fine.
Could there be something weird in your git config or setup? It seems that Best cannot read your git configurations properly.
from best.
I tried a fresh checkout of best repo and the condition is that the current branch has to be tracking something that is not [origin/master]
, this is my fresh setup (do this while on master
):
git branch --track bad
git branch good
git branch -vv
bad 0c1ef01 [master] feat: rewrite of Agents, Hubs, Remotes and Algo (#217)
* good 0c1ef01 feat: rewrite of Agents, Hubs, Remotes and Algo (#217)
master 0c1ef01 [origin/master] feat: rewrite of Agents, Hubs, Remotes and Algo (#217)
best runs fine on branch good
(which tracks nothing) and branch master
(which tracks [origin/master]
) but fails on branch bad
(which tracks [master]
)
from best.
But given the conditions, this is a low priority issue because there is a workaround.
from best.
Are you saying that the issue only happens when you have multiple local branches pointing to the same remote master?
from best.
Mh, no, even one branch causes the error, I just pulled new master from best and these are the simplest repro steps I was able to come up with:
Do this while on master
(after a fresh build):
git branch --track bad
git checkout bad
cd packages/lwc-example/
yarn start
This yields
Looking for Best configurations...[WARN] - Unable to get git information
ERROR Error: Unable to read git information
at generateProjectConfigs (/Users/manuel.jasso/dev/github/best/packages/@best/config/build/index.js:17:19)
at readConfig (/Users/manuel.jasso/dev/github/best/packages/@best/config/build/index.js:77:45)
at processTicksAndRejections (internal/process/task_queues.js:97:5)
from best.
I was able to reproduce as well. I think I am understanding this better now.
So this is happening when you create a local branch that tracks another local branch.
I am un-aware if this is very common behavior or not, as I have never needed to do this. I will see what I can do to figure out a fix though.
from best.
Thanks, I know tracking a local branch makes no sense, this was just my simplest repro steps, I saw this error without tracking a local branch but I don't remember what I did, my hope is that the scenario will help you identify a problem which is not specific or related to tracking local branches. And like I said before, there is a workaround so this is not a high priority.
from best.
Related Issues (20)
- Making @best/cli leaner HOT 1
- Unexpected benchmark run order
- Feature request: ability for agent to register multiple specs against hub HOT 2
- Warmup runs
- Memory usage tests HOT 2
- Node version incompatibility HOT 1
- Locker Integration breaks with version 4.0.0-alpha10 upwards (Runs fine with 4.0.0-alpha8 & 9) HOT 2
- CLI has vulnerable yargs version HOT 1
- Benchmark run fails. Possibly related to puppeteer HOT 1
- feat: add support for table driven testing with benchmark.each() HOT 1
- Error: You must provide specifications for the runner in your best config. HOT 1
- Best fails to start on git origin that doesn't end on `.git`
- benchmarkIterations not respected when set in best.config.js
- Storing artifacts on S3 fails on CI
- Support functions in plugins array
- Benchmark outputs are missing when cwd is not best project root
- Security Vulnerability with systeminformation (npm), Affected versions < 4.31.1
- Docs: clarify if/how this can be used for non-browser benchmarks HOT 1
- Update rollup dep HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from best.