ServerApplication may throw NPE when run in headless mode

Perform a null check in ServerApplication line 40!

Add logger.debug() statements to the ApiClient

Rename request-encoder to response-encoder

Request doesn't need to be encoded. This was probbably a typo.

Remove RelayMode.all()

This is not needed as Java Enum provides values() method.

When relay does not succeed the client connection is not closed.

Enable Maven check-style plugin to enforce clean dependency hierrarchy

SMTP can't be restarted predictably

SmtpServerTests are failing because the server can't be restarted predictably

00:04:38,712: Starting SMTP server on port: 2500...
00:04:40,887: Stopping SMTP server...
Exception in thread "Thread-0" com.dumbster.smtp.exceptions.SmtpException: java.net.BindException: Address already in use: bind
    at com.dumbster.smtp.transport.SmtpServer.run(SmtpServer.java:77)
    at java.lang.Thread.run(Thread.java:745)
Caused by: java.net.BindException: Address already in use: bind
    at sun.nio.ch.Net.bind0(Native Method)
    at sun.nio.ch.Net.bind(Net.java:444)
    at sun.nio.ch.Net.bind(Net.java:436)
    at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:214)
    at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
    at io.netty.channel.socket.nio.NioServerSocketChannel.doBind(NioServerSocketChannel.java:104)
    at io.netty.channel.AbstractChannel$AbstractUnsafe.bind(AbstractChannel.java:464)
    at io.netty.channel.DefaultChannelPipeline$HeadHandler.bind(DefaultChannelPipeline.java:1032)
    at io.netty.channel.ChannelHandlerInvokerUtil.invokeBindNow(ChannelHandlerInvokerUtil.java:99)
    at io.netty.channel.DefaultChannelHandlerInvoker.invokeBind(DefaultChannelHandlerInvoker.java:196)
    at io.netty.channel.DefaultChannelHandlerContext.bind(DefaultChannelHandlerContext.java:366)
    at io.netty.channel.DefaultChannelPipeline.bind(DefaultChannelPipeline.java:898)
    at io.netty.channel.AbstractChannel.bind(AbstractChannel.java:189)
    at io.netty.bootstrap.AbstractBootstrap$2.run(AbstractBootstrap.java:309)
    at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:318)
    at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:353)
    at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:794)
    ... 1 more
00:04:45,352: Stopped SMTP server
java.lang.IllegalArgumentException: [Assertion failed] - this expression must be true
    at org.springframework.util.Assert.isTrue(Assert.java:65)
    at org.springframework.util.Assert.isTrue(Assert.java:77)
    at com.dumbster.smtp.transport.SmtpServer.start(SmtpServer.java:49)
    at com.dumbster.smtp.transport.SmtpServerTest.startSmtpServer(SmtpServerTest.java:207)
    at com.dumbster.smtp.transport.SmtpServerTest.setUp(SmtpServerTest.java:46)

Process finished with exit code 0

Notes

The assertion directly after starting server is failing. The synchronization of SMTP server should be done in the same way as that for the API server.

Remove MailMessages entity

I guess we can use XmlWrapperElement to get rid of the entity altogether.

Use Log4j 2

Upgrade to Log4j 2

Match package name aligned to the group-id/artifact-id

Change package name of the Java classes so that they are aligned to the group-id.

Use synchronized storages in DAO

Add build status to github using travis-ci

https://github.com/heroku/heroku-buildpack-java

Dependencies not injected properly to ApiServerHandler

This results in NPE at the API server whenever client sends a message to the server because the API server does not have any dependency injected.

Use Mockito for unit testing

Should be possible to select type of storage in ServerApplication.

Use command line arguments and properties file.

Cleanup tests

Currently the test uses way too many overloads of sendEmail method. Make them use EmailSender

SmtpMessagesTest fails when all tests are run

SmtpMessagesTest fails when all tests are run, especially the test that use special characters. Surprisingly, the test passes when I run only the tests from the class.

This might be issue related to

encoding bytes from netty using UTF-8 and that from email might be different
dirtied spring context

Implement API client using netty/TcpClient and provide it with the api package.

Rename Storages to DAO

All storage classes and methods could be renamed to DAO because the abstraction layer is actually a DAO

MailStorageTest not working

Wire all spring dependencies in tests so that MailStorageTests pass.

Use Spring for dependency injection

Make API server use netty

Quoted-printable with soft line breaks not parsed properly

Hel=\n
lo

Should be parsed as

Hello

More info: http://en.wikipedia.org/wiki/Quoted-printable

Inject storage mode using Spring properties

Change the SMTP implementation so that it uses Netty

API server can't be restarted predictably.

ApiServerTest.restartApiServerMultipleTimes() fails.

Increment the number of restarts to 10 and make the test pass!

Inject dependency during test using Mockito

Might be possible by adding some annotations or wiring to TestInfrastructure.

@ContextConfiguration(locations = {"classpath:/application-config.xml"})

Improve the build by not restarting test infrastructure before each method.

Affected tests

ApiClientTest
ApiServerTest
SmtpMessageTest
SmtpServerTest

saksham / hulaki Goto Github PK

hulaki's People

Contributors

Stargazers

Watchers

Forkers

hulaki's Issues

Notes

Recommend Projects

Recommend Topics

Recommend Org