saba-var / covid-quoestionnaire Goto Github PK

https://github.com/RedberryInternship/covid19-Var-Saba/blob/e0e5191f2dbac37203f1606ec6c87018a80a5e6f/src/state/form-context.js#L24-L56

https://github.com/RedberryInternship/covid19-Var-Saba/blob/0936010d24935f9972da5e9f52f0da0fe81abd53/src/components/InputWrapper.js#L1

i needed to look into your code and i was playing around with it and found this bug

input field length increases when there is error message bellow,

this doesn't look like ones in design please remove red BG

https://github.com/RedberryInternship/covid19-Var-Saba/blob/7e22f879100324ae5cca120b3b05f54be3c90e16/src/Pages/Covid/Covid.js#L16-L22

do this for every use effect

https://github.com/RedberryInternship/covid19-Var-Saba/blob/6d0afd0ed03ada8d0975585a7b93a55a45dad863/cypress/integration/end2end.test.js#L53

https://github.com/RedberryInternship/covid19-Var-Saba/blob/e0e5191f2dbac37203f1606ec6c87018a80a5e6f/cypress/integration/covidPage.test.js#L3-L64

https://github.com/RedberryInternship/covid19-Var-Saba/blob/e0e5191f2dbac37203f1606ec6c87018a80a5e6f/cypress/fixtures/example.json#L1-L6

on this last page only left side schould be scrollable

changes should reflect on server

P.S do not forget to clear cache/change browser page title and favicon stay in browser cache for a while

https://github.com/RedberryInternship/covid19-Var-Saba/blob/7e22f879100324ae5cca120b3b05f54be3c90e16/src/App.js#L1-L7

here are instructions on how to do it -> https://dev.to/mr_frontend/absolute-imports-in-create-react-app-3ge8

i just noticed this, no need to type your own version of git commit rules, u can just link our article about it in resources

add section for Cypress with instructions how to run it, and include it in tech stack

use this as reference https://github.com/RedberryInternship/example-project-react

do not forget to first remove

https://github.com/RedberryInternship/covid19-Var-Saba/blob/6d0afd0ed03ada8d0975585a7b93a55a45dad863/cypress/support/commands.js#L57

https://github.com/RedberryInternship/covid19-Var-Saba/blob/e0e5191f2dbac37203f1606ec6c87018a80a5e6f/cypress/plugins/index.js#L1-L24

so i think u missunderstood me, u need to gitignore cypress.json only when u put sensitive info in there, in this case u shouldn't, and if u do gitignore here is what u should do: make cypress.json.example, and put some dummy info there, without including sensitive info, u should put name of that sensitive info just do not pass vlaue of it, and when someone copies this files they will run this command on ubunut: cp cypress.json.example cypress.json and they will put real values, now i can not run tests because of missing baseURL,

dw u do not have to change imports for this

pages shouldn't really have scroll on my screen

first of all try to not combine multiple naming styles,(kebab-case, snake_case, camelCase, PascalCase) and instead stick to one, and second is extract this svgs into react components and put them in components/svgs folder, its much eaiser to use them and u can even configure them easly via passing props, and use PascalCase when u move them to components,

please avoid using names like this they aren't really descriptive, not just this ones same goes for suggestion1 and files like that

https://github.com/RedberryInternship/covid19-Var-Saba/blob/6d0afd0ed03ada8d0975585a7b93a55a45dad863/cypress/integration/end2end.test.js#L76-L78

https://github.com/RedberryInternship/covid19-Var-Saba/blob/2b8feae242ff808cd164d0e0b0b79ecb1c0a9049/cypress.json#L5

didn't notice this before