sa2c / cupybe Goto Github PK

The examples should have a uniform coding style.
The ones created by me differ in style from the ones created by Chenna in this regard.
Mainly, the issue lies in the documentation at the beginning.

Expand the possibilities for metric conversions (if asking cube_dump directly for the inclusive metrics is not enough).

At the moment, there is a series of tests that are run sequentially with a script.
The functionality of this script can be replaced by a standard automatic test framework.

It would make sense to refactor the tests so that they can be run with pytest. There are at least two options:

• refactor the tests so that each script is entirely contained in a function that pytest can discover and run
• use the trick mentioned here https://stackoverflow.com/questions/56807698/how-to-run-script-as-pytest-test to run the scripts one by one using pytest parametrize decorator.

These are just suggestions, the goal is to use a proper test framework instead of a bash script that can be difficult to maintain.

It would be good to have CI set up for this project with all the fancy things such as coverage and badges.
This would be better done once issue #6 is taken care of.

A license must be added to the code.

The functions create_node* in the calltree module have a lot of code in common.
It would be better if the duplicated code were removed with a refactoring.

The system tree should be easy to implement extending the same machinery used for the call tree.