s7u4rt99 / ped Goto Github PK

edit 1 -name abc sets the name of the first student in the list to ame abc. It should throw an error as the flag is wrong.

Great idea to include the popup window for help which brings us directly to the UG DG, instead of the original one with the link which is more troublesome. However, there is a bug where if we click the github icon, we are unable to navigate back to the UG/DG webpage after viewing the github (Yes, we can use the UG DG on the github under the docs folder, but it is not as clean as the original one, and other users may not know where to find it in the source code). Even if i close the help window and open it up again, it is still on the github page. The only way is for me to close the app entirely, re login again and then i am able to access the UGDG. This can cause a bit of inconvenience to some people. However, i understand that it may not be entirely in your control as it is an external webpage, but i do hope that you guys would look into this issue. Thanks.

Zip file for the recording as it was a bit too big

When I import a csv file with someone who's name is already in the contacts, it does not get added.

Before importing

importing file

result

Sometimes the flag requires us to put a "" around the values, but sometimes it does not. If it is standardised, it would be much clearer.

Screen Recording 2021-10-29 at 4.46.47 PM.mov

It sets the name as ame jh if i use a -name instead of --name. I do not believe this is the intended behaviour. Perhaps it should throw an error when that happens.

As you can see from this example, it is hard to tell what The given password is invalid means. Does it mean my new password is invalid or my old password invalid? Perhaps it can be clearer what it means. Maybe it can say: The new password is invalid OR You entered a wrong old password.

As you can see, the edit command on the UG and SPAM gives very different examples. The UG says that each field has to be wrapped in "" with a space after the flag (edit "1" -n "damith") but the example SPAM gave did not use "" and also did not leave any space after the flag (edit 1 -p91234567 [email protected]). Perhaps it can be clearer which to use.

Before importing

Screenshot of my csv file

After importing

How to recreate:

1. export contacts into a csv file
2. add a new name below the last person with no other details other than the name, and save it
3. clear the contacts on the app
4. import the same csv file

Note:

• Once i removed the last entry with only the name, it is able to load the file.
• When i had a working contact book, deleted all their details manually in the app (edit 1 -p -a -e -t) and exported them out, and tried loading them back, it works. But when i filled in their phone number for all of them except the last one in the csv file, it is unable to load again, producing the same bug. When i deleted all their phone numbers again to see if it works again like the first time, it suddenly does not work anymore.

I hope that you guys are able to fix this bug because this import and export feature is very cool! :)

In the help menu, when i click the github logo, some of the tabs (such as the pull requests, issues, and projects which are supposed to be next to the discussions and actions tabs) are missing as seen here. It only appears when my mouse hovers over them. Not sure if this bug can be controlled by you guys or not.

The constraints say that names should only contain alphanumeric characters and spaces. However, based on this definition of alphanumeric characters, symbols should be allowed for names but it is not allowed, even though numbers are.

Unfortunately, there is no way to reset the password. To continue using the application, you need to move the encrypted data file to a different location or delete it. The application will create a fresh data set for you to start over with.

It is amazing that your team was able to use encryption for tp! However, something that can improve the clarity of your UG is that not many people may know what the encrypted data file refers to in this section. Perhaps by giving the file path (data/addressbook.enc) it would be clearer.

The values of the flags are supposed to be in "" but it works without.

edit 1 -e [email protected]
edit 1 -n nwefaom

Here are just a few examples but it does not work for all of the flags.

When i import a csv file with 15 rows of data with the same person, the result says that 15 Contacts added successfully, even though only 1 new contact has been created as they were duplicates.

Before importing

CSV file i imported

Result

The constraint says that the local-part of the email should only contain alphanumeric characters, which consists of symbols like * and &. However, it is not accepted by the app.

When i run the edit 8 -n hello command without the"", it still edits the contact's name. However, the user guide says that it has to be wrapped with "". Hence the correct way should be edit "8" -n "hello". It should not accept edit 8 -n hello.

Screen Recording 2021-10-29 at 5.06.42 PM.mov

Even though i copied the exact example edit command given in the user guide, it does not work on my application.

If any of the fields are very long for some reason (name, email, address, etc), we may not be able to see it, especially if it is longer than the width of our entire screen. Maybe you can add a horizontal scroll bar so that even though it may be long, we are able to scroll horizontally to see it.