rynr / netio Goto Github PK

The result of invoking readLine() is dereferenced without checking to see if the result is null. If there are no more lines of text to read, readLine() will return null and dereferencing that will generate a null pointer exception.

Dereference of the result of readLine() without nullcheck in org.rjung.netio.NetworkSwitch.loginConnect() lineNumber 126
Dereference of the result of readLine() without nullcheck in org.rjung.netio.NetworkSwitch.loginSendCredentials() lineNumber 99

Found a call to a method which will perform a byte to String (or String to byte) conversion, and will assume that the default platform encoding is suitable. This will cause the application behaviour to vary between platforms. Use an alternative API and specify a charset name or Charset object explicitly.

Found reliance on default encoding in org.rjung.netio.NetworkSwitch.getPassword(): String.getBytes() lineNumber 113
Found reliance on default encoding in org.rjung.netio.NetworkSwitch.loginConnect(): new java.io.InputStreamReader(InputStream) lineNumber 121
Found reliance on default encoding in org.rjung.netio.NetworkSwitch.loginConnect(): new java.io.OutputStreamWriter(OutputStream) lineNumber 123

As a developer
*I want" to have standard logging
So that I don't need to think about dependency updates.

Acceptance Criteria

• The project does not have a library dependency for logging

Nothing helps you more to understand a library than just seeing how it works.

Calling String.toString() is just a redundant operation. Just use the String.

org.rjung.netio.NetworkSwitch.loginConnect() invokes toString() method on a String lineNumber 126
org.rjung.netio.NetworkSwitch.loginSendCredentials() invokes toString() method on a String lineNumber 99

Currently the class is not tested.

This plugin currently uses the telnet-interface to the netio-module.
To not take care of the network-connection, it's probably more reliable to use a http-interface.