Coder Social home page Coder Social logo

action's People

Contributors

ryanve avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

Forkers

web5design

action's Issues

CSS layout class prefix

In 1.0 I used l- as a prefix for layout modifiers (applyable via skins).

  • .l-lheader - aligns <header role="banner"> to left
  • .l-rmenu - floats .site-nav to right
  • .l-rsidebar - floats .main-widget-area to right

l- is somewhat standard and terser than layout- but is it enough?

WAI-ARIA and hash jumps

Versions 1.1- have included <a class="assistive" href="#main"> . It seems like this could be redundant for screenreaders with proper WAI-ARIA support.

Ideal CSS file structure in parent theme

action should use the CSS file setup that best enables child-theme flexibility while still remaining maintainable and performant. The parent CSS is organized and modular. For performance it is usually ideal for all CSS to be combined in 1 file. 2 files is reasonable and easier to maintain. It helps separate base from theme styles.

0.x file structure

1.0 file structure

Both queue setups (0.x, 1.0) allow any file to be overrided by a child theme. A WP problem is that child themes must contain style.css. The setups above allows modular overriding without needing @import. They rightfully nudge child-theme devs towards cascading rather than editing base styles.

What setup provides the easiest usage to child themes?

One alternative is manually combine everything into style.css and not use a css folder. If a child wants to use the parent stylesheet, it can enqueue it via its functions.php. It'd simplify the parent file structure and improve front-end performance. But it'd make customization less modular and the parent CSS messier. The 0.x setup hybridizes the 2 extremes.

stylesheet [media] types

Action uses #2 stylesheets for mainly for maintainability and modularity. A positive side-effect is that the 2nd sheet is only loaded on applicable media types.

<link rel='stylesheet' href='/wp-content/themes/action/base.css'>
<link rel='stylesheet' href='/wp-content/themes/action/style.css' media='screen'>

Maybe [media="screen, projection, print, tv"] is appropriate but its hard to decide without access to other types. Which types should the theme include by default? Test media types and the demo site.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.