ryancmann / osesmo Goto Github PK

It seems that the "Storage Only" model in python is currently unusable due to a couple of errors:

1. The script is assigning the wrong variable. For example, at line 2047, you assign a "Solar_Only_" variable:

if Model_Type_Input == "Storage Only":
    Solar_Only_Peak_Demand_Reduction_Percentage = ""

But then at line 2066, you reference a "Solar_Storage_" variable:

 if Model_Type_Input == "Storage Only":

        if Solar_Storage_Peak_Demand_Reduction_Percentage >= 0:

            print('Peak demand with storage is {0} kW, representing a DECREASE OF {1}%.'.format(round(Annual_Peak_Demand_with_Solar_and_Storage, 2), round(Solar_Storage_Peak_Demand_Reduction_Percentage, 2)))

This is leading to a "variable referenced before assignment" error

2. Even if the correct variable name is assigned, you are assigning it to the value "", which is interpreted as a string, so that when you try if Solar_Storage_Peak_Demand_Reduction_Percentage >= 0, you get TypeError: '>=' not supported between instances of 'str' and 'int'

These issues appear to repeat through the end of the code for peak demand, annual energy consumption, and emissions impact calculations.