ruxandrafed / contacts-list

Hi there 👋

Software Architect at #paid • Certified Kubernetes Administrator • AWS Certified Solutions Architect • Women Who Code Vancouver Legacy Director

🔗 www.ruxandrafediuc.com

💼 LinkedIn

🐦 Twitter

contacts-list's Issues

Review

For something like

  def to_s
    "\nID:\t\t#{id}\nFirst name:\t#{firstname}\nLast name:\t#{lastname}\nEmail:\t\t#{email}\nPhone numbers:\t#{phone_numbers.map(&:to_s).join(', ')}".colorize(:yellow)
  end

take a look at HEREDOC strings

http://blog.jayfields.com/2006/12/ruby-multiline-strings-here-doc-or.html

Review

Sometimes when there is too much logic in one statement, it is probably a good idea to move them into two lines e.g.

arr[index,5].each do |arr|
  puts "#{arr[0]}: #{arr[1]} (#{arr[2]}; #{arr[3].gsub(/[\[\]""]/, "")})"
end 

instead of

arr[index,5].each{|arr| puts "#{arr[0]}: #{arr[1]} (#{arr[2]}; #{arr[3].gsub(/[\[\]""]/, "")})"}