ruuda / bs1770 Goto Github PK

Hello, I'd like to know if the album gain for multiple tracks depends on the order that those input tracks are passed into the included flacgain utility. I'm including bs1770 in a personal tagging project, and I need to know if I need to pre-sort my tracks by track number to get a correct album gain.

The Rust guidelines suggest public API types should implement Debug.
https://rust-lang.github.io/api-guidelines/debuggability.html#c-debug.

Currently this is not the case for Power and ChannelLoudnessMeter.

When calculating the gated mean of audio that is pure silence, it appears the power result (and also the result of loudness_lkfs()) is NaN. In this case, I'd expect a result like -infinity.

It's unclear to me what the correct behaviour is in this case - a low power value might be sufficient, but as at this is likely going to be used to normalize audio, maybe the gated mean should return an enumeration which can encode that it failed to find any audio above its gating value (which I assume is what happens here).