Thunderbird version about awesome-emoji-picker

[tdulcet]

@rugk and I published an experimental version of the Awesome Emoji Picker for Thunderbird: https://addons.thunderbird.net/en-US/thunderbird/addon/awesome-emoji-picker/. It requires Thunderbird 91, which was just released last week. Feedback is welcome.

It includes the emoji autocorrect feature from #93, as well as a context menu item to fix #45. Note that the emoji picker and emoji autocorrect feature currently only work in the message body of the compose window.

[tdulcet]

Bug 1641577 has finally been fixed, which was the last blocking bug (see #49 (comment))! Unfortunately, they will not uplift the fix to the current Thunderbird 78 release, but it is now available in Thunderbird Beta and will be available in the next major version, Thunderbird 91, which is currently scheduled for release on August 10.

[rugk]

Yeah, I need to look into it (whether Thunderbird supports WebExtensions)…

[tdulcet]

Thunderbird does support WebExtensions: https://thunderbird-webextensions.readthedocs.io/en/latest/

[rugk]

Thanks for the pointer. That's great to hear, but it needs to be looked into whether it can be made compatible/needs adjustments.

[tdulcet]

I just filed a bunch of bugs with Thunderbird that would need to be fixed to get the Awesome Emoji Picker fully working:

• https://bugzilla.mozilla.org/show_bug.cgi?id=1641573 (FIXED TB 80, uplifted to TB 78.1.1)
• https://bugzilla.mozilla.org/show_bug.cgi?id=1641575 (WONTFIX, users will not be able to insert emojis or do autocorrection in the message subject)
• https://bugzilla.mozilla.org/show_bug.cgi?id=1641576 (FIXED TB 82, uplifted to TB 78.4)
• https://bugzilla.mozilla.org/show_bug.cgi?id=1641577 (FIXED TB 86, will not be uplifted to TB 78)
• https://bugzilla.mozilla.org/show_bug.cgi?id=1641580 (FIXED TB 87 in bug 1681153, will not be uplifted to TB 78)
• https://bugzilla.mozilla.org/show_bug.cgi?id=1716295 (added June 14, 2021)
• https://bugzilla.mozilla.org/show_bug.cgi?id=1725144 (added August 11, 2021, FIXED TB 93, uplifted to TB 91.1.2)

this to fix #45, #100 and #106:

• https://bugzilla.mozilla.org/show_bug.cgi?id=1656506 (added July 31, 2020, FIXED TB 89, will not be uplifted to TB 78)
• https://bugzilla.mozilla.org/show_bug.cgi?id=1716199 (added June 14, 2021)
• https://bugzilla.mozilla.org/show_bug.cgi?id=1716976 (added June 17, 2021)

and this would make debugging easier:

• https://bugzilla.mozilla.org/show_bug.cgi?id=1641574 (FIXED TB 80 in bug 1650149, uplifted to TB 78.1.1)

Even with these bugs/missing features, I was able to get the emoji picker and autocorrect (#93) to work in Thunderbird's compose window with very minimal changes.

[rugk]

Wow thanks. Good work! 😃

[rugk]

Issue #1641577 has a workaround posted, does this fix the problem, @tdulcet?
If so, I've converted your list above to a checklist, so let's tick the issues that are solved…

[tdulcet]

Issue #1641577 has a workaround posted, does this fix the problem

No. With the workaround, the options page will load, but changing the options has no effect.

If so, I've converted your list above to a checklist, so let's tick the issues that are solved…

OK, I marked the bugs that have been fixed. At a minimum, we only need 1641577 and 1641573 to be fixed to get this working. The rest either are missing features (1641575 and 1641576) or will eliminate Thunderbird specific code that is currently required (1641580).

As soon as #93 is merged, I will create a PR for this, so that people can test it out. Note that Thunderbird 78, the next major version, is currently scheduled for release on July 17. Thunderbird follows the Firefox ESR release schedule, so there is only a major release every year.

[dvergeylen]

I've tested with Thunderbird 91.1.0, under Debian Testing Wayland.

I'm experiencing a weird flickering of the menu when clicking on it. Does not appear 100% of the time, I'd say roughly 90%.

output.mp4

That might not be related to the addon at all (which I extensively use with Firefox 🙏).

[rugk]

Oh gosh, this looks like some (P)ReactJS rendering issue or whatever… Does it matter, where on the screen you place the window before opening the popup?

Because in your video/GIF (thanks BTW for that, this is very helpful!) I can see it that the height you have available is not much, the popup just fits on the screen.
So maybe move the window up a bit and then the popup has enough space to be shown? (I'm just speculating here…)

[dvergeylen]

Does it matter, where on the screen you place the window before opening the popup?

It doesn't, but that might be a hint: whatever the window position and size, the menu tries to get as much height as it can (resulting in too big emojis, proportionally with the rest of the interface) until it collides with the bottom of the screen. I guess it can't find a correct "non colliding" position and starts flickering by repositioning itself again and again... 🤔

I don't experience the issue in Firefox 91.1.0esr.

Hope this helps!

[rugk]

Given the same engine etc. should be underlying Firefox and Thunderbird, maybe we should consider opening a Thunderbird bug for that? Or do you have any other ideas, @tdulcet?

[tdulcet]

Given the same engine etc. should be underlying Firefox and Thunderbird, maybe we should consider opening a Thunderbird bug for that? Or do you have any other ideas, @tdulcet?

No, I definitely agree that someone should create a bug on BMO with the above video, as this is most likely a Thunderbird/Gecko issue since the whole popup flickers/flashes.

@dvergeylen - Thanks for reporting this! I noticed in your video that there is another format toolbar icon for a different add-on. Do you have any issues with the popup for that? I agree that the popup in your video is a little bigger than I would expect: