Comments (15)
Screen shot - sure - I don't have the firefox version.
from awesome-emoji-picker.
Thanks for all the investigation. I've opened TinyWebEx/AutomaticSettings#23 for it. Also removed the Thunderbird tag as it thus also seems to affect Firefox.
from awesome-emoji-picker.
Could you provide a screenshot please, maybe? 😊
Also, does that only happen in Thunderbird or is it also reproducible in the Firefox version of the extension?
from awesome-emoji-picker.
/cc @tdulcet
from awesome-emoji-picker.
If I chenge TB color settings to
never override - then the preferences work fine.
However the preview pane in TB now has white background which is horrible for dark theme - so I need to set to override always for TB to be reasonably sane.
Can't say if this is TB bug or by design :) or if there's anything addon can do - but that what I see...
from awesome-emoji-picker.
Also, just in case this be helpful, I have 2 other addons and they both work fine (cardbook and dkim-verifier)
from awesome-emoji-picker.
What do you mean with these overwrite settings? Do you have a support link or a screenshot of the setting, which causes the issue here?
from awesome-emoji-picker.
In thunderbird : settings -> language & appearence -> colors
In the popup window there is a drop down as shown here:
from awesome-emoji-picker.
So some background that may help you to understand what is happening: Without overwrite it should honor prefers-color-scheme
, i.e. your system/browser's design/theme, in dark it will have a dark background and light text and in light vice versa.
So when you overwrite that in your browser via some overwrite, that will of course fail, respectively Thunderbird must somehow honor that.
I am still not sure what exact combination of settings causes this. Does the OS theme also influence it? Does "use system colors" make a difference? What else other than "always override" can you select there? Etc. etc.
The other sections are legible but not brilliantly so (Details, Permissions and Release notes).
Also note that this is 100%ly rendered and handled by Thunderbird itself, and the extension only provides the content/text, but Thunderbird does all the rendering and design there. Only the settings itself can be influenced.
from awesome-emoji-picker.
Thanks for doing research / follow up. The option to use OS theme makes no difference - starting to seem like this may well be bug with TB - for sure without that 'override' setting there are parts of thundebird that do NOT respect dark theme which is why it was necessary.
Hey if you feel this is really all TB fault feel free to close this one out.
Its not critical, as one can always turn off the override - make whatever settings you want and then turn it back to keep TB usable.
from awesome-emoji-picker.
Hey if you feel this is really all TB fault feel free to close this one out.
I'll wait for @tdulcet 's reply on that, he has more insight into Thunderbird.
Anyway, in the mean time, if you think this is a bug in Thunderbird you may open a bug report for them, respectively search for existing reports, also/or look into the support forum.
from awesome-emoji-picker.
cool thanks!
from awesome-emoji-picker.
I'll wait for @tdulcet 's reply on that, he has more insight into Thunderbird.
A quick check shows that the options page in Thunderbird works as expected with the dark mode without this override:
Although I can confirm the issue when enabling the override:
However, enabling the same override in Firefox causes the same issue:
This override seems to enable the high contrast mode (see here and here) which it not yet well supported by Firefox/Thunderbird (see bug 1016556 and bug 1619744). Although, I checked the options pages for a few other add-ons in Firefox and most did not have this issue, so I would say it is likely a bug with the CSS used by the AutomaticSettings library (it probably needs to be checking prefers-contrast).
starting to seem like this may well be bug with TB - for sure without that 'override' setting there are parts of thundebird that do NOT respect dark theme which is why it was necessary.
Yeah, the fact you need to enable this override at all to make the dark mode work as expected in Thunderbird means that there must be other bugs in Thunderbird. I would encourage you to file bugs on BMO for those.
from awesome-emoji-picker.
Seems its a known bug https://bugzilla.mozilla.org/show_bug.cgi?id=1690531
@tdulcet give your detailed understanding how TB works, it would be helpful if you added your thoughts to the bugzilla?
thanks
from awesome-emoji-picker.
@tdulcet give your detailed understanding how TB works, it would be helpful if you added your thoughts to the bugzilla?
My knowledge is just about TB extensions, since I ported this add-on and several others to TB, so unfortunately I do not think I would be much help with that bug... Hopefully they will be able to get it fixed for you.
from awesome-emoji-picker.
Related Issues (20)
- Exhale emoji is missing 😤 HOT 3
- Options (dropdown etc.) need to be clicked further down than where they are shown HOT 3
- Emoji v13/v13.1/v14/v15/v15.1 support HOT 13
- Make a version of Awesome Emoji Picker for google chrome HOT 4
- add twemoji support to awesome emoji picker HOT 1
- Apple/Google/Twitter/Facebook styles don't display in Thunderbird HOT 4
- Doesn't work properly on Thunderbird HOT 1
- Alternate Emojis not displayed on Instagram. HOT 1
- Widen the scope from emoji input to more general Unicode character input ? HOT 4
- [Thunderbird] No emojis visible after one selcted HOT 8
- Using the Add-on 0.9.1 with Thunderbird 102.0b7 - Hitting enter once when composing an email has the effect of hitting enter twice HOT 8
- addon breaks composer HOT 3
- Cannot re-enable auto correction in version 0.9.2 HOT 4
- Be able to disable "Searching for emojis [...] is disabled" in address/search bar HOT 6
- Please add lungs 🫁 HOT 2
- Web-ext lint fails on CI
- Add emoji selector to context menu (right click menu) HOT 1
- Chrom/ium support (after manifest v3) HOT 4
- Switch to manifest v3 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from awesome-emoji-picker.