Coder Social home page Coder Social logo

rubixdev / inventorio Goto Github PK

View Code? Open in Web Editor NEW
56.0 4.0 19.0 1.12 MB

Inventorio - an inventory enhancement mod for Minecraft (Fabric / (Neo)Forge)

Home Page: https://modrinth.com/mod/inventorio

Java 33.89% Kotlin 66.11%
minecraft minecraft-mod minecraft-fabric minecraft-forge fabric forge mod

inventorio's Issues

[FABRIC] Expected Crash w/ VanillaDeathChest

With maximum Deep Pockets enchantment, player inventory can exceed a double chests worth of inventory space, causing a crash when VanillaDeathChest attempts to container these items.

I can crosspost this to their issue tracker instead since it is technically a limitation by their mod, however compatibility with other gravestone-esque mods should be considered.

You can also consider making Deep Pockets toggleable in the configuration file as an end-all-be-all solution. I would instead daydream about Inventorio support for the many Backpack mods, or its own implementation.

Log:
latest.log

Mods:
image

Unknown Crash Report

For some reason I keep getting this crash when launching the game.
I have a couple of mods installed but I can't find the reason why it is crashing now.
Without any other mods or just a few it seems to work just fine.

Crash report

Updating world without this mod deletes offhand item

If you create a world without this mod then put an item into off-hand slot then add the mod, the item in the off-hand slot is deleted. It would be ideal if the item got put into the utility belt when adding this mod.

fabric V1.1.0
1.16.4

[BUG] Weird Levitation Issue With Deep Pockets Enchantment And Hookshot Mod

Here's how to replicate the issue: While pulling yourself up using the Hookshot mod (as shown below), just press and hold the space (or jump) button to levitate up in the air. This will only work, if and only if, the leggings that you have has a deep pockets enchantment.

Before putting on the leggings with deep pockets enchantment:
https://user-images.githubusercontent.com/64238265/123504127-115bec80-d68a-11eb-81a8-af93684ad0ee.mp4

After putting on the leggings with deep pockets enchantment:
https://user-images.githubusercontent.com/64238265/123504146-26388000-d68a-11eb-86aa-ac4d3037cbcd.mp4

P.S: As you can see, the diamond leggings have multiple enchantments but I tested a separate case in creative mode where the deep pocket enchantment is only present in the item. The bug also works with any leggings too (leather, iron, gold, diamond, and netherite).

Edit: You don't need to actually press and hold the space button to levitate.

[Suggestion] Better Totem Activation

It would be nice to have the totem activate if it is anywhere in the utility belt or maybe inventory. A custom slot for the totem would also work.

Conflict with Diet mod

image

I think you might be adding a button where diet also adds one, which create the weird double button look

[Suggestion] Allow empty hands in Utility Belt

Allow us the ability to select an empty slot in the utility belt. Currently, this is not possible since it always selects any item present in the slot and skips the empty ones. Sometimes there are just certain actions that requires an empty hand to be used.

Very weird behavior with Requiem and Gravestones

No idea where I should report it so imma just put it on all three githubs I guess.

Using
Inventorio https://github.com/Lizard-Of-Oz/Inventorio
Gravestones https://github.com/Geometrically/Gravestones/issues
Requiem https://github.com/Ladysnake/Requiem

If you die while possessing a mob, weird stuff happens.

  • a grave gets created, but most of the items just fall out like normal rather than go into the grave
  • your currently selected hotbar slot, offhand slot gets deleted
  • your currently selected toolbar slot (i was mining while it happened) gets duped

My inventory before I died
image

My inventory after I died BUT before I broke the grave (all these items were on the ground)
image

My inventory after picking up what was in the grave too
image

[Bug] Mod overlaps with JEI Show recipes feature.

Minecraft version: 1.16.5
Forge version: 36.1.24
Inventorio version: 1.3.0
JEI version: 7.7.0.104

Issue: Inventorio overlaps with the JEI show all recipes feature in the player inventory.

Summary:
JEI uses a feature that makes a "button" that shows all recipes for any and all types of crafting you wish to see (furnace, brewing stand, crafting table, etc).
image_2021-06-08_02-13-36
This feature extends to the player inventory placing the "button" where the arrow would be. Inventorio pushes the 2x2 crafting grid and output to the side but the show recipes feature remained in place with the button overlapping with the crafting grid of the player inventory.
image_2021-06-08_02-14-14

Attempted troubleshooting: I determined it was indeed JEI that had the show recipes feature as removing the mod also removed the feature. Removing inventorio with JEI installed put the inventory back to where it was and had the show recipes button back over the arrrow next to the 2x2 crafting window. I checked JEI's config to see if there was a means of disabling said feature but it does not appear there is a option.
image_2021-06-08_02-38-56

Dupe Glitch On Servers

Fabric V1.2.0
1.16.4

I am having trouble reproducing this, so this is based on what a player in my server says. I am hosting the server on my own network and they are far away so their ping is much higher. They were able to reproduce relatively consistently.

  1. Have item in utility belt (they had 6)
  2. Open 2nd instance of minecraft under the same account
  3. Try joining server with second instance of minecraft, then hit cancel after it kicks the first instance out and the moment before you join the server
  4. The item you are holding in your utility belt is sometimes duped

Weird key priority when pressing keys in quick succession with segmented hotbar

Right now, if you quickly press two keys (eg. 1 and 2) and the second key is pressed down before the first key is released, the slot that ends up selected is inconsistent.
Rather than selecting the number 1 segment and number 2 slot in it, it selects the number 1 slot in the number 1 segment.
Seems like the lower number gets priorized regardless of which key gets pressed down later, if the key that was pressed down first is still being held down.

example:
key inputs of: press down 2, press down 3, release 2, release 3 end up with second slot in second segment

[Suggestion] Auto Refill

Since other mods auto refill functions don't apply to the toolbelt, perhaps an option that allows you to toggle auto refill as part of Inventorio would tie in nicely.

[Request]: config to disable auto toolbelt switching

I like everything this mod does except the automatic tool switching.
I've never been a fan of automatic things like this, just my opinion.

Could we get a config to disable this an instead control which tool is selected with:

  • modifier key+scroll
  • modifier key+number

Basically it would work like the utility bar, but without the offhand swap functionality and with the limitation to just tools.
Maybe you could render the toolbelt slots either on the opposite side of the hotbar from the utility belt or as a vertical mini-hotbar in the bottom left or right corner of the screen.

BUG [1.16.5] Items disappearing in Utility belt slot after a random amount of time.

Suppose that you have a shield, crossbow, and a torch on your utility belt (or if you have a grapple gun mod, a grapple gun) [link: https://www.curseforge.com/minecraft/mc-mods/hookshot]. After a random amount of time while playing Minecraft. Items start to disappear, and I am sure that I didn't drop any of it or stored it in any chests. The items will completely disappear even though the items are in full durability. There are two things that I know of, one is that it only happened to me four times (and more as I play) and the items that disappeared are: 3 shields (unmodded), and a grapple gun (modded). Two, it likely happened during those times that I lagged, specifically server lag or TPS lags. Anyway, I will watch your career with great interest, have a nice day ahead, thank you!

P.S: There is also a time where my Diamond Pickaxe was dropped even though it is in my tool belt while mining for blocks (specifically dirt blocks using Diamond Shovel). Though, I suspect that I just pressed Q randomly during that time and it might not be a bug.

Suggestion, Items Stored in Deep Pockets

I was thinking for the deep pockets enchantment instead of just dropping the extra items on the floor when taking the pants off, it could store the items within the pants almost like how a shulker doesn't drop the items when broken. But if the enchant gets wiped off of the pants with a grindstone it could then just drop all the items like it currently does. This could also potentially be a setting in the world config for people who prefer one way or the other? Thanks for reading!

[Suggestion] An option to let us scroll into an empty offhand slot

Some features of some mods require you to have both hands empty, some people are more used to putting stuff in their offhand by scrolling onto the thing and swapping hands with hotkey.

Also about the broken tool auto swapping last time. Inventory Profiles completely ignores the toolbar slot tool, Tweakeroo replaces it but places the replacement on your selected hotbar slot rather than into the toolbar. Both work fine if the tool is on hotbar.

Instant Mining Issues On Servers

Using the toolbelt with instant mining tools on servers sometimes stops the instant mining process and tries to mine with the item in the main hand. This makes instant mining kind of annoying. It might be able to be replicated in singleplayer, but it seems to work a lot better.

fabric V1.1.0
1.16.4

If you aren't able to replicate, I am using the spellbound enchants mod and the rock collector enchant, which helps me instant mine.

2021-05-20.17-50-45-1.mp4

Delay before being able to use item after mining even when switching hotbar slots manually

My axe toolbelt slot is empty, but I have an axe in my hotbar. When I use that axe to cut some wood and then swap to a potato, the axe doesn't go away for like a second and I can't eat it until the axe goes away.
Food isn't the worst but I could see this killing people if they need to epearl or blockclutch.

Ideally the delay wouldn't be there even when using toolbelt.

Broken Slot Compatibility for All Tools from Tetra and Tinkers Construct

Tools from Tetra with the (I think singular shared) item ID "tetra:modular_double" and tools from Tinkers Construct with IDs like "tconstruct:pickaxe", "tconstruct:hand_axe", etc don't go into the tool slots for automatic use from inventory, which is a genuine bummer right now without a configurable whitelist built into Inventorio for manual editing/fixing.

"tetra:modular_double" should probably be allowed in any slot given how wildly customizable they are.

tconstruct:pickaxe, tconstruct:sledge_hammer, tconstruct:vein_hammer really should be allowed in the pickaxe slot, tconstruct:mattock in either any hatchet, shovel, or hoe slot, tconstruct:excavator in the shovel slot, tconstruct:hand_axe and tconstruct:broad_axe in the hatchet slot, tconstruct:kama, tconstruct:sword, and tconstruct:cleaver in the sword slot, and tconstruct:scythe in the hoe slot. An argument could be made for tconstruct:sledge_hammer and tconstruct:broad_axe in the sword slot as well, but really just being able to use those as default tools in the belt as intended by Inventorio would be a really welcome enhancement.

The scroll order of the utility belt should be reversed

This has been bugging me for the longest time and I couldnt figure out why. I thought I'd just get used to it but I kept scrolling into the wrong slot. I finally figured out why lol.
In vanilla, when you scroll down, it selects the slot on the right of the one you are currently using.
When scrolling through the offhand slot, the opposite happens. The item highlighted on the left gets chosen.
Also makes more sense in inventory, since right now scrolling down selects the item thats above your currently selected item.

Or at least it would be a nice config option.

Edit: apparently i forgot which side is right and left lmao

Cannot raise shield in offhand.

Can't be a compatibility issue, tested it with just the mod by itself and it still persists. Appears to happen in all slots. Can still raise shield in main hand, just not any off-hand slots.

[Compatibility] Epic Fight: Combat Mode

Would it be possible to add compatibility to Epic Fight's combat mode so when you enter the mode it will use your weapon out of the weapon slot and/or utility belt if you have one and also have the ability to switch out weapons.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.