rubenj01 / dndonline

D&D Online

Hi there 👋

My name is Ruben and im a software engineer student from the Netherlands. Im always interested in collaborating on projects so feel free to reach out.

🔨 Languages and Tools

🔥 ​Statistics

📫How to reach me:

• Discord: RubenJ01#0001
• E-mail: [email protected]
• LinkedIn

dndonline's Issues

Detailed description

Add a more detailed description to the commands.
We currently only have a brief for every single command and i want to expend that to detailed descriptions for each command that includes command formatting.

Reworking ;stat ;rngstat and ;rngstat3

These commands do the same thing but then a different amount of times. For example:
;rngstat - roll 6 ability scores
;rngstat3 - roll 3 ability scores
;stat - roll 1 ability score
Im gonna rework this command into 1 command that can roll up to 18 ability scores.

Combat tracker still not working

Switch over to a different host

I should set up the different host somewhere arround this week. This will be a huge improvement from what we are currently using.

Clean up all imports

Remove all of the necessary imports for the files

Separate alias file

Create a separate file with alliasses, command briefs and commands description so i can modify something quicker as it will be alphabetically sorted.

Implement new briefs and descriptions

Implement the new briefs and descriptions to all the commands

Merge all cogs to one core 'cogs' folder.

Cogs are supposed to keep similarly-themed commands together for better organization. In its current iteration, the bot has two separate cog subfolders: corecogs and taverncogs.

Both of these subfolders should be merged into the base cogs folder, and all cogs fro. taverncogs should be merged into a megacog, taverncog.

Single stat rolls not displayed in embed

;stat gives raw text as output instead of an embed

Dice modifers

Add modifiers to dice rolling so instead of:
;roll 1d20
you can do:
;roll 1d20 +5 or for multiple dices: ;roll 1d20 +5 1d8 +3

Create ;special

Command that pulls up all special features for the rp section in the tavern rp section.

Listing aliases in ;help not working properly

When adding aliases to commands it adds the same command twice to the list instead of adding the alias.

Create command descriptions

Write more detailed command descriptions that specify: formatting, meaning and its general purpose.

New format for ;encounter

Change the current formatting on the ;encounter command to something more represenitive

Embeds per command, not per if statement

I've noticed a lot within the codebase that you open a ton of Embeds per command, depending on the parameters passed to them, such as the following, as found with Commit eba510b:

	if number == "8":
		embed = discord.Embed(
        		colour = discord.Colour.blue()
    		)
		embed.add_field(name="8. How do I apply for Staff? - #faq", value="Currently, new Staff applications are closed.  However, the Staff list does change occasionally. If you would like to signal your interest in being a staff member one day, feel free to fill out the application for the Advisors (trial moderator) role in #announcements." + "\n" + "Remember, we always keep an eye out for users who are regularly active, and who are generally kind, considerate and helpful to their fellow users. When you step up, we notice.", inline=False)
		await bot.say(embed=embed)
	if number == "9":
		embed = discord.Embed(
        		colour = discord.Colour.blue()
    		)
		embed.add_field(name="9. What is the Hall of Fame? - #faq", value="The Hall of Fame is reserved for users who have distinguished themselves in some way.  Users who are particularly funny, helpful, knowledgeable, clearheaded, etc. may one day find that the staff have voted to give them a golden hero’s crest.", inline=False)
		await bot.say(embed=embed)
	if number == "10":
		embed = discord.Embed(
        		colour = discord.Colour.blue()
    		)
		embed.add_field(name="10. What does [abbreviation] mean? - #faq", value="See the #faq for a full list of all abbrevations.", inline=False)	
		await bot.say(embed=embed)```


This seems like a large amount of wasted lines, as each parameter creates the same Embed object without changing titles or descriptions. Creating the embed at the top of the command and adding fields depending on passed parameters looks much more clean, and prevents repetitive code.

Add in remaining classes

Classes.json still missing a few classes

Error in ;status

servers = len(bot.servers)
NameError: name 'bot' is not defined

Indent error in faqcommand.py

Split up main.py

Split the last few remaining commands up in cogs

Single rolls not displayed in embed

Add in remaining conditions

Still some conditions missing in the ;condition command

Migrate to Rewrite

Discord.py async has not been updated since Nov 13, 2017. That being said, we should eventually look to move over to the rewrite branch of the library. More updated, less convoluted. This doesn't have to be done immediately, but should eventually get done.