rubengarciam / wayne

Comic Book Manager & Reader

wayne's Issues

Comic Vine metadata API

One of my biggest concerns with Comic Vine's API is the harsh rate limiting they impose:

We restrict the number of requests made per user/hour. We officially support 200 requests per resource, per hour. In addition, we implement velocity detection to prevent malicious use. If too many requests are made per second, you may receive temporary blocks to resources. These features are included to help keep the API healthy for all of our users. If you have a question regarding rate limiting, please comment in our API Developer forum. It is suggested that you cache responses in your app to prevent duplicated requests from making unique requests.

This may require every user to create its own API key, as it won't scale otherwise

Reader menu labels are not aligned

Describe the bug
Reader's menu uses SwiftUI's Label in a VStack. However, the system icons and text are not aligned, as each image has its own independent width (vs having a shared width and being horizontally centered(

Raised a ticket with Apple: #FB7986805

Offline view is not scrollable when grid is on

Describe the bug

The Offline view is not scrollable when the comics are displayed in a grid view.

Edit multiple comics is broken in v0.3.0

Describe the bug

The toolbar icon doesn’t bring the Edit Comics view in the main Library view

Set the first page as the comic’s cover

Describe the solution you'd like

Feedback by @miguelangelgras

My opinion is that it is easier and comfortable to set the first page as cover by default as most of applications do.
Dragging and dropping from web can be enough for few comics but for large collections is very time consuming

A clear and concise description of what you want to happen.

Additional context

This would require stream download every single item in the library, extract the first page and then discard he downloaded content.

It was discarded for the first release because it wouldn't seem scalable for large libraries.

It would also require an update to the data model to save the cover's data, which will increase the data synchronized over iCloud/CloudKit.

Select a specific page as the comic cover

Add page zooming support in the reader

Double tap to zoom

Describe the solution you'd like

Enable double tap to zoom. Pan to the tapped area

Local NAS support

Sign In with Apple

Is your feedback related to a problem? Please describe.

When I try to connect to my Dropbox account from the Wayne app, Dropbox does not show an option to Sign in with Apple (which is what I use to login to Dropbox). This might be a bug from Dropbox’s part, I’m not sure. Just thought I should let you know.

Submitted via email

Google Books metadata API

Describe the solution you'd like

Add Google Books as a metadata source

Suggest removing the download when the comic is read

Describe the solution you'd like

After the user has finished reading the comic, suggest removing the locally downloaded file.

Alternatively, create an option to configure the behavior when the comics is marked as read:

• Automatically delete the downloaded file
• Suggest deleting the downloaded file
• Do not delete the downloaded file

Comics cannot be opened in search when grid is on

Describe the bug

When the grid is on, results from a search cannot be opened. It works fine in list view

Cursor support

Move the menu to a sidebar

SidebarListStyle

Change “None” placeholder

Substitute “None” for something more descriptive in each view:

• Not collected
• No series
• No story arc
• No publisher
• No author

DatePicker interface

Describe the bug
Swift 5.3's DatePicker is at odds with the rest of the forms components

Screenshots

Cover image search

Is your feature request related to a problem? Please describe.

Scrap the web for the the comic cover based on the comic title

Sidebar's group broken behaviour

Xcode 12b2 has broken sidebar's outline group's behaviour. Now the parent group title is selectable and opens an empty view, leaving the sidebar in a weird state

Save progress before closing the reader view

Describe the solution you'd like

At this point in time, reading progress is only saved when the reader view closes.

It might be a good idea to save the progress every time the user opens a new page. Sometimes you might be reading a comic and putting it to sleep, without closing the reader view.

This might incur in more CloudKit read/write operations though.

Add a "Select All" option

Color themes

Add support for themes using SwiftUI's accentColor

Add lazy loading for grids and other stacks

When filtering by authors, display just the authors selected

Describe the bug
When a specific author is added to the filters, all other co-authors for the filtered comics are displayed too.

To Reproduce
Steps to reproduce the behavior:

• Comic has authors author_1, author_2
• Add author_1 to the filters
• Open the Group By Authors view
• Author_1 and Author_2 are displayed

Expected behavior
Just show the selected authors, not comic’s co-authors

Enable iCloud Drive

Is your feature request related to a problem? Please describe.

As part of the steps required to support iCloud #15, we have to enable and create a folder in iCloud Drive.

Google Drive support

• Google Drive OAuth
• Renew OAuth2 certificates when expired
• Select root folder
• Scan cloud files
• Look for changes in files
• Download
• Download Progress
• Extract contents for reading
• Evict local files
• Delete cloud files

Cursor support in Swift5.3

Describe the bug
Cursor support in Swift5.3 is not there yet, definitely not on par with UIKit.

Using the trackpad behaves erratically too. I need to double-tap vs the expected single-tap and sometimes the button view disappears (?)

Screenshots
Attached are some screenshots that show how it compares:

• Default navigation button
• Toolbar button with padding
• Toolbar button without padding

Additional context
Related to #11

iCloud support

Mark comic as read when the user opens the last page, not when the closing page is the last page

Describe the solution you'd like

Right now the comic is marked as read ONLY when the reader is closed and the current page is the past page.

A user might reach the final page but browser back a number of pages for any particular reason.

The comic should be marked as read the moment the last page is opened.

Navigation bars is missing accent colors

Describe the bug

There seems to be a bug in the latest Xcode12 beta-3 whereby some views might lose the configured accent color.

It also seems the sidebar items UI is broken for dark mode.

To Reproduce

Steps to reproduce the behavior:

1. Go to Library
2. Minize sidebar
3. Open any comic
4. Open Goodreads search sheet
5. See error: accent color is lost, both for the sheet and sidebar title

Screenshots

Update app for iOS 14

• beta 1
• beta 2
• beta 3
• beta 4
• beta 5
• beta 6
• GM

Known SwiftUI bugs

• Sheets might disappear without notice
• Sidebar items UI glitches

Migrate from Ubooquity library

iCloud Drive files: Button doesn't display correct state after removing extracted files and evicting local file

Describe the bug

The button still shows "Extract", even though the file has been removed and evicted.

To Reproduce

Steps to reproduce the behavior:

1. Go to a comic from iCloud Drive
2. Download if necessary
3. Remove extracted files
4. Evict local file
5. See error

Kitsu metadata API

Describe the solution you'd like

Add kitsu.io as a metadata source

Add Sentry.io SDK to start collecting crash logs

Is your feature request related to a problem? Please describe.

Sentry.io
Sentry.io Privacy Policy

Identification of the User

By default, we don’t apply the user identification provided to the SDK via the API. Instead, we use the installation ID generated with the first use of the application. The ID doesn’t contain any private or public data of your users or any public or shared data of their device.

In-app feedback/bug reporting

Add a feedback/bug form in the app that creates a new issue in this repository

Add a link back to Goodreads for those comes that have been populated with its data

Describe the solution you'd like

Adhere to Goodreads terms of service:

Clearly display the Goodreads name or logo on any location where Goodreads data appears.

Link back to the page on Goodreads where the data data appears.

Simulate Apple Music’s search interface and animation

When a new comic is added it is not immediately available in the "Recently Added" view

Describe the bug

The comic doesn't show up in the "Recently Added" view right after it is added. However, it is available in all the other views.

Applying a filter or restarting the app makes it available

To Reproduce

Steps to reproduce the behavior:

1. Add a new comic
2. Scan the Library
3. Go to the Recently Added view
4. Comic is not there

Placeholder for future file services

Is your feature request related to a problem? Please describe.
At this point in time, Wayne only supports Dropbox and it is designed to only have a single cloud storage.

Modify the metadata to specify which file storage it comes from, as the the user will be able to connect to one or more file storages in the future.

Finish adding @fire-bot to your repo

Greetings, fire here!

@rubengarciam recently invited @fire-bot to this repository. Before fire is enabled, @rubengarciam needs to complete a few steps:

Complete fire setup now

Only @rubengarciam will be able to enable fire using the above link. If someone added fire by mistake, feel free to remove @fire-bot from your repo's collaborators.

Description background

Describe the bug
Swift 5.3 introduced the TextEditor view (yay!) but its background always matches the system background (vs being clear or the parent view background)

Screenshots

Edit multiple comics: add “ignore” options

Is your feature request related to a problem? Please describe.

Add the option to ignore multiple comics at once.

Deletion will remain at an individual action for now (to prevent unintented mass deletion)

List’s section headers color background

Describe the bug
List’s section headers color background doesn’t match the view background

Additional context
Swift5.3 still has no modifier for section’s background color

Metadata sources

This is a list of possible metadata sources considered

• Goodreads
• Google Books
• ComicVine

---

Goodreads

Goodreads is a social cataloging website that allows individuals to search freely its database of books, annotations, quotes, and reviews.

• goodreads.com
• api
• guidelines & terms
• #50

🟢 Completed

---

Google Books

Google Books is a service from Google Inc. that searches the full text of books and magazines that Google has scanned, converted to text using optical character recognition, and stored in its digital database.

• books.google.com
• api
• guidelines & terms
• #48

🟢 Completed

---

Marvel

---

DC Comics

---

Comic Vine

The largest comic database online, Comic Vine features Comic Reviews, News, Videos, and Forums for the latest in and more!

• comicvine.gamespot.com
• api
• guidelines & terms
• #52

🟢 Completed

---

Kitsu

Kitsu is a modern anime discovery platform that helps you track the anime you're watching, discover new anime and socialize with other fans.

• kitsu.io
• api
• guidelines & terms
• #51

⚫️ Rejected

---

Anime News Network

Anime News Network is an anime industry news website that reports on the status of anime, manga, video games, Japanese popular music and other related cultures within North America, Australia, Southeast Asia and Japan.

• animenewsnetwork.com
• api
• guidelines & terms
• #53

⚫️ Rejected

iCloud Drive setup flow

Is your feedback related to a problem? Please describe.

The iCloud Drive setup flow is not straightforward enough.

After the user authorizes iCloud Drive they only see the readme file in their library but no comics. They might not know that they have to add comics to the newly created Wayne folder in their iCloud Drive.

Example: @Fear - Wayne doesn’t work for me. Just found a comic in my ICloud Library, and is not a comic, is a read me.
Are you using the iCloud account or Apple ID? My iCloud account is different to the Apple ID.
Describe the solution you'd like

Display a placeholder text describing what to do.

Mac support

Planned macOS support. Probably just for ARM-based Macs initially

iCloud files might display size = 0

Describe the bug

Depending on whether the file is locally available in the device or not, the size of the file will be displayed as 0MB or its actual size

Reader Improvements

Loading Speed

Improve the pages initial loading phase to speed showing up the current page.

In/Out Grid Transitions

Add in-and-out transition form the current page to its corresponding page in the grid.

Migrate from Calibre