rubberduck-vba / battleship

An Object-Oriented VBA experiment

rubberduck-vba

Github-Pages rendering at rubberduck-vba.github.io

battleship's Issues

"Merciless" strategy should be allowed to place adjacent ships

It could avoid adjacent ships 90% of the time, but not making it systematic would add to the unpredictability of the strategy.

Some of the GameController logic needs to be extracted to a ClassicMode class

In order to extend the game with different/custom modes (e.g. Salvo mode), the GameController logic around alternating player turns needs to be extracted to some IGameMode interface that is implemented by a ClassicMode class for the current logic, and could eventually be implemented by a SalvoMode class.

Annotations need to be updated

Rubberduck 2.4.0 (re-)introduced module/member attribute annotations; the code should be updated to reflect proper usage; a number of @Description annotations are illegal, module-level ones need to become @ModuleDescription annotations, and @PredeclaredId is missing in a number of classes.

AttackResult shapes should be images

The appearance of the "HIT!", "MISS", and "SUNK" labels/shapes will be different than intended on machines that don't have the font that was intended. Cutting the shapes and re-pasting them as images should fix it (making sure they keep the same name).

Remove the RubberDuck Add-In, if it is not needed...

😃

Excel2013+ bug high CPU load if Freeze Panes line is zoomed out of sight

Excel 2013+ seems to have a bug such that if you Freeze Panes and zoom in so that the freeze line is out of sight it starts to recalculate the worksheet's display constantly thereby causing high CPU load. In order to limit the scroll area and keep the battle fields on display use the worksheet property ScrollArea and limit to $A$1:$AF$32 as in the attachment.
Excel2013up-bug_frozenPanesOutOfSight.xlsx

Game won't run on a Mac

Win32 API calls need to be adapted to work on a Mac.

Game won't run on Excel 2007

Quick-Fix:

• To run on Excel 2ßß7, theLongPtr's in Win32API-Module need to be changed to Long.

• TextFrame in GameSheet.ShowInformation is missing property .VerticalOverflow, Comment it out and game runs.

Conditional-Compling onVBA7forLongPtrand onVersionfor the missing property should solve that issue. I'll try over next week.

Needs a UserForm UI

The game should be extended with a dynamic UserForm UI that implements the IGridViewCommands interface and offers a completely different user experience.

"Acquired targets" gives away too much information

In a human-vs-AI game, there should be some configuration at the beginning of a game, that lets you pick whether the "acquired targets" box is...

• Always hidden
• Hidden until a ship is sunken (current human-vs-AI behavior)
• Hidden until a ship is hit (current AI-vs-AI behavior)

Add test category annotations

Replace @Testmethod with @Testmethod("XXX"), where XXX - name of the module without the "Test" suffix to show test categories in the test explorer.

Add VB6 build

Given that almost all the modules are host-agnostic (kudos!), it should be possible to ađd a .vbp and a new view to allow the same codebase to be compiled as a standalone executable. Bonus points for adding CI with unit tests :-)

Unit Testing - Compiler Directives

Could you use Compiler Directives to require the Rubberduck add-in only during Unit Testing?
#Const UnitTestMode = False
Public Const UnitTestMode As Boolean = False
#If UnitTestMode Then
Private Assert As Rubberduck.AssertClass
#Else
Private Assert As Object
#End If

Add a "Salvo" mode

Currently blocked by #7

Once there's an IGameMode interface, the game needs a SalvoMode implementation so that each turn consists of:

• "Marking" positions on the enemy grid (click to mark, right-click to un-mark).
• Handle a double-click to confirm marked positions and shoot them all at once.
• Number of positions to mark depends on the number of friendly ships still afloat.
• Number of shots per ship could be configurable, e.g. Carrier could shoot 2 positions if unharmed, or 1 if damaged; or, each ship afloat gives player 1 position to mark per turn.

The GridState enum could have a MarkedPosition value that recycles the InvalidPosition member's value, which is currently only used in the deployment phase. Because of Worksheet UI limitations with the conditional formatting of the grid, no new enum values can be added.

GameSheet needs a "Play Again" button

When the game ends, it should be possible to start a new game directly from the game screen.