rtfeldman / elm-workshop Goto Github PK

This PR #6 address this issue.

Thanks!

Hi, thanks for this workshop.

I have some issues to run tests on part 9

cd part9
elm package install -y && (cd tests && elm package install -y)
elm test

-- NAMING ERROR - /Users/trapcodien/trap/elm/elm-workshop/part9/tests/HtmlRunner.elm

Cannot find type `Model`

14| main : Program Never Model Msg
                         ^^^^^


-- NAMING ERROR - /Users/trapcodien/trap/elm/elm-workshop/part9/tests/HtmlRunner.elm

Cannot find type `Msg`

14| main : Program Never Model Msg
                               ^^^


Detected errors in 1 module.
Compilation failed while attempting to build /Users/trapcodien/trap/elm/elm-workshop/part9/tests/Auth.elm /Users/trapcodien/trap/elm/elm-workshop/part9/tests/HtmlRunner.elm /Users/trapcodien/trap/elm/elm-workshop/part9/tests/Main.elm /Users/trapcodien/trap/elm/elm-workshop/part9/tests/Tests.elm

I tried to delete tests/HtmlRunner.elm file, then i have this error :

Success! Compiled 1 module.
Successfully generated /dev/null
I cannot find module 'Test.Runner.Failure'.

Module 'Test.Reporter.Console.Format' is trying to import it.

Potential problems could be:
  * Misspelled the module name
  * Need to add a source directory or new dependency to elm-package.json
Compilation failed for /Users/trapcodien/trap/elm/elm-workshop/part9/elm-stuff/generated-code/elm-community/elm-test/src/Test/Generated/Main3385995764.elm

Did i miss something ?

Hi @rtfeldman,
firstly thank you for all your fantastic content
and all you have (already) done to make the Elm community so welcoming, inclusive and fun!! 😍

Secondly, apologies for this essay of a issue,
we hope it will be worthy of your time to read & reply to it!

Why?

We have been learning elm for a while
and were delighted to discover that you had made the time to
record a video series for FrontEnd Masters (FEM)!

At least 5 people on our team have subscribed to FEM
specifically to access your workshop videos,
and we expect many more to follow in the next few weeks/months
as we transition our stack from Redux+React/Riot.js+etc. to Elm.

(So) What?

Last year when we were learning how to use Redux
we followed Dan Abramov's Egghead Video Series
and made complete transcriptions/notes for all the videos:
https://github.com/dwyl/learn-redux/{link-to-md-file}
These proved quite popular in the community for many reasons:

• Accessibility for hearing impaired people who can follow the words
  in the transcription while playing the video adjacently.
• Improve the UX for non-native english speakers who may not understand
  every word that is said (we think your pronunciation/diction is great,
  but you would be surprised how often people struggle to
  comprehend accents they are unfamiliar with...)
• The transcriptions could be used to enable a "Subtitles" Feature which could
  be used to translate the content into many other languages thus opening it to
  new audience/market(s)...

Long-story-short, as part of Learning Elm, we have started transcribing Your FEM Lectures: https://github.com/dwyl/elm-workshop/blob/transcript/part1/transcript.md

Without going too much further, we want to request your
"blessing" to continue and suggest
that we send you a Pull Request for you to integrate the Transcripts back into
your elm-workshop repository.

If "enhanced transcription" is already being worked on by someone at FEM we are happy
to halt our efforts to avoid duplicating effort. But if nobody is (already) working on it,
we will gladly do it because transcribing ensures our
own understanding of the material and improves the learning/comprehension
for everyone in the community.

How? (Proposal)

We propose a divide-and-conquer approach where a pair of people transcribes
each video while they are following the videos for their own personal learning.

We will organise the the transcript.md into the the 14 Parts
of the elm-workshop so that all future Elm learners can follow along
while they are watching your FEM videos.

When?

We would allocate 20 people; 2 to each of the 10 videos
and you would receive 10 Pull Requests over the next few weeks.

>> Please let us know your thoughts either way on this so we know if we should continue (send you PRs) or stop! (thanks!!)

Who (are "We"...)?

We are a community of Web Application Developers based in London (UK)
(but increasingly distributed around the world)
We build Web Apps for clients ranging from "startups" to fortune 500 companies.
As previously mentioned, we are going to be switching from Redux+React+etc. to Elm
for all projects for the foreseeable future
(because we ❤️ the community-spirit / clear leadership+vision / features / platform / ecosystem)!

What?

We used Redux+React+etc. for several internal & client projects last year,
some of them reached substantial levels of "complexity"
(hundreds of Reducers/React Components over tens of thousands of lines!)
so your video on 6 Months of Elm in Production talk really resonated
with us! Elm is the "whole package" whereas virtually everything else
is a list of ingredients which only partially achieve
the benefits of the Elm Architecture/Debugger/Ecosystem
and we're really excited to start using Elm for our next client project(s)
(for which the client has already signed off on us using Elm+Phoenix
and to keep the entire codebase 100% Open Source!!)
and we expect to contribute back to the community with
improvements to learning resources, PRs with bug-fixes and
general evangelism (and even potential remote team members for "NoRedInk",
but let's not get ahead of ourselves!! 😉)

We expect that FEM Elm Workshop/Course will be a catalyst for the expansion
of the Elm community in 2017 and we would love to contribute to enhancing it!

Many thanks (again)!
Yours in Elm,
Inês
( DWYL, Founders & Coders, Ladies Of Code ❤️ ✅ )

Note: We acknowledge that transcribing your FEM lectures could be perceived
as a "copyright infringement" by some legal people
(who may not "get" why this will enhance the content and not undermine it!)
but we would urge anyone who thought that way to consider that
by having the verbatim transcriptions more people in the community
will be able to follow them which will lead to greater adoption of Elm in 2017.
Arguably the improvement in accessibility to elm-workshop will result
in more people subscribing to FEM in order to access the Videos
in order to accelerate their Elm learning.

I'm trying to put the pluralize function into the repl which I have done but it produces > pluralize <function> : a -> a -> number -> a rather than <function> : String -> String -> Int -> String` which I cant figure out..

I believe this commit is where the material splits away from the recorded version.

In another issue on this repo I see that this might be a continuing problem throughout the course:

"I realize this means the code is out of sync with the slides in this section...sorry about that! I plan to do a refresher course with Frontend Masters sometime around early 2018, which will bring everything up to date!"

Surely there's a better way to approach this — either by putting the updated materials on a new branch/repo, or at least putting some notes in the repo and/or on the video to warn students.

Download this:

elm-stuff.zip

Unzip into your elm-workshop directory - it should be a directory called elm-stuff, and if you already have an elm-stuff directory there, this should replace it.

~/Code/elm-workshop/part1
master ❯❯ elm-live Main.elm --open --pushstate --output=elm.js
zsh: command not found: elm-live

Seems like https://github.com/tomekwi/elm-live isn't in the elm-package.json, should it be?

Thanks!

I've installed latest elm, but I don't have elm-package on the command line.

How hard would it be to update this tutorial to latest build chain?

I went to part1/ and ran elm-upgrade and got elm make Main.elm to compile
but then elm-live Main.elm --open --output=elm.js returns:

elm-live:
  I can’t find the command elm-make!
  Looks like elm-platform isn’t installed. Make sure you’ve followed
  the steps at https://git.io/elm-platform and that you can call
  elm-make from your command line.

In the Part 7 solution Frontend Masters Elm video @ the 3:00 minute mark, Mr. Feldman uses the 4.0.0 elm-lang/core api when writing the Task.perform function, which takes three arguments. Documentation can be found here.

However, the elm-lang/core dependency version referenced in elm-package.json is 5.0.0 <= v < 6.0.0. Here is the Task.perform documentation for version 5.1.1. It only takes two arguments.

I think the best course of action to simply roll back the elm-lang/core dependency to 4.0.0 and maybe leave 5.0.0 as an exercise left up to the reader once they feel comfortable with Elm. That's just my two cents though.