rstemmer / libprinthex

🔧 A library to print a buffer as typical hex-view with highlighted regions on the console screen.

Hi 👋

---

libprinthex's Issues

test.sh produces weird output

The output from the test.sh:

The output is reproducible by building the docker image

docker build . -t showdump

using the following Dockerfile:

FROM ubuntu:latest
RUN apt-get update && apt-get install -y clang git libz-dev
RUN git clone https://github.com/rstemmer/libprinthex.git
RUN cd libprinthex && ./build.sh && ./install.sh
WORKDIR /libprinthex
CMD [ "bash", "./test.sh" ]

and running it:

docker run showdump

Create man-page

Use clang for compiling and fix warnings

Currently I still call gcc in the build.sh script.
This should be changed to clang (LLVM is the future).

When using clang, I get the following warnings: (one more reason to use clang ;) )

printhex.c:76:20: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
            printf(color);
                   ^~~~~
printhex.c:76:20: note: treat the string as an argument to avoid this
            printf(color);
                   ^
                   "%s", 
printhex.c:81:20: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
            printf(color);
                   ^~~~~
printhex.c:81:20: note: treat the string as an argument to avoid this
            printf(color);
                   ^
                   "%s", 
2 warnings generated.

These should be fixed as well.