Comments (12)
Thinking about it a bit, we should probably have another alg which does a preselection (but not necessarily selecting dilepton WW) and reserve this name for the SR selection algorithm.
from factorytools.
Sorry - Can you say what you mean more specifically? So we have a preselection alg (which does what kind of preselection. i.e. common to what regions) and then a separate for a proper SR?
The total output of this whole package should be at "preselection" level (at least defined in the same way as the 0L factory) right? So it seems like there still should just be for a given analysis N select functions. So like Select[AnalysisName][Region] as the name. SelectDileptonicWWSR, SelectDileptonicWWCR1L, etc, where each is to the preselection level.
Do you think that would work or do you have something else in mind that I'm missing?
from factorytools.
I guess I was saying (poorly since I'm not exactly sure what I meant) that if some selection is the same between all of the regions it should be in a separate alg. Something like the Meff and MET(') cuts from the factory. Does that sound good?
(This also fits with the fact that I have the other algs separately listed).
from factorytools.
Oh I see. Yes ok. So should this actually be done at something like a post-selection level? Because e.g. let's say we wanted to cut on something like MET(') for all regions - The definition of MET(') is only set per region, right? (Think 0L CRY.) But on top of that, we may want to add an overall cut on an RJR variable instead. So this cut would have to be done after the calculateRJigsawVariables alg. So maybe we have a "selectDileptonicWWCommon" which is after the RJR calculation alg. Does that make sense?
from factorytools.
Sorry for the slow response. Yeah, I think something like that makes a lot of sense though.
from factorytools.
Cool. I was thinking about it the other day, and for things like cleaning, GRL, etc, we'd for sure want something common as well. But maybe that means we should have a pre selection and post selection algorithms? Not the best, but if we only had one, we would be doing unnecessary calculation for e.g. everything that's not in the GRL.
So maybe it should be like "preselectDileptonicWWCommon" and "postselectDileptonicWWCommon". Maybe I'll work on trying to port that kind of stuff over..
from factorytools.
Yeah, that sounds great!
from factorytools.
Created in #20. Will keep open until a more mature preselection is implemented.
from factorytools.
GRL, Trigger, PRW, Bookkeeping, duplicate events are taken care of in the basic event selection algorithm provided by xAODAnaHelpers. Included in #23.
from factorytools.
And actually it takes care of event cleaning too.... We'll keep the preselection algorithm in case we come up with something we want to do with that... It that might be a useless alg in the end.
from factorytools.
MCVeto needs to go in here.
from factorytools.
MCVeto was actually added in a separate MCEventVeto alg. Done in #32.
from factorytools.
Related Issues (20)
- SampleHandler failure to find files doesn't offer any info HOT 2
- running in 20.7 HOT 1
- proper CBK finding HOT 1
- automatic "*.root" appending to end of .ds HOT 11
- Check on updates from xAODAnaHelpers HOT 1
- Merging script needs to count from metadata output
- Expected output file *._000002.hist-output.root does not exist HOT 1
- Dynamic derivation configuration HOT 2
- Wjets SR region not filling HOT 4
- Smart calculator option passing HOT 1
- Trigger not applying / LumiCalc issues HOT 8
- Running Factory Tools code HOT 2
- Memory Usage Too High HOT 7
- How do we have have the same lepPt in hte next event? HOT 6
- Fat Jets retrieval when derivations don't have them HOT 1
- Output histograms to tree output stream HOT 1
- Move all output from MeV to GeV HOT 2
- Fix compilation warnings
- Clean up datasets
- Validation against ZeroLeptonRun2 factory HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from factorytools.