Comments (7)
Or actually maybe it is... I'm going to try and clean some stuff up.
-L
from factorytools.
I've narrowed it down to the RJigsaw calculator. Removing that algorithm from the job leads to stable memory usage.
from factorytools.
I no longer see a memory leak and feel like a crazy person. I guess the scouting job is what measures the required memory? I'm back at square one.
from factorytools.
Ok I can see that if I comment out all of the algorithms except BasicEventSelection, there's no memory growth. The memory leak starts with CalibrateST.
In the execute call of CalibrateST, I've narrowed it down to the Get* calls to ST:
https://github.com/rsmith54/FactoryTools/blob/master/Root/CalibrateST.cxx#L207
Once L207-246 are uncommented, the leaking starts...
Maybe this is something we need to bring up with Martin+Zach?
Investigating.
-L
from factorytools.
Haha! Appears to be taus. Damn taus...
I'm going to comment out the GetTau call in CalibrateST and test on the grid.
from factorytools.
this appears to be entirely from the GetTaus() call in the CalibrateST alg.
Commenting out this line appears to remove the memory leak.
Memory usage on lxplus node after 10k events
Only BasicEventSelection+CalibrateST (w GetTaus() call) - 4.7%
Only BES+ST (no taus) - 3.1%
Entire job (no taus) - 3.1%
Without the leak, should be able to run stably within 1 GB of RAM.
from factorytools.
Fixed in #124
from factorytools.
Related Issues (20)
- SampleHandler failure to find files doesn't offer any info HOT 2
- running in 20.7 HOT 1
- proper CBK finding HOT 1
- automatic "*.root" appending to end of .ds HOT 11
- Check on updates from xAODAnaHelpers HOT 1
- Merging script needs to count from metadata output
- Expected output file *._000002.hist-output.root does not exist HOT 1
- Dynamic derivation configuration HOT 2
- Wjets SR region not filling HOT 4
- Smart calculator option passing HOT 1
- Trigger not applying / LumiCalc issues HOT 8
- Running Factory Tools code HOT 2
- How do we have have the same lepPt in hte next event? HOT 6
- Fat Jets retrieval when derivations don't have them HOT 1
- Output histograms to tree output stream HOT 1
- Move all output from MeV to GeV HOT 2
- Fix compilation warnings
- Clean up datasets
- Validation against ZeroLeptonRun2 factory HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from factorytools.