Coder Social home page Coder Social logo

Comments (7)

lawrenceleejr avatar lawrenceleejr commented on July 23, 2024

Or actually maybe it is... I'm going to try and clean some stuff up.

-L

from factorytools.

lawrenceleejr avatar lawrenceleejr commented on July 23, 2024

I've narrowed it down to the RJigsaw calculator. Removing that algorithm from the job leads to stable memory usage.

from factorytools.

lawrenceleejr avatar lawrenceleejr commented on July 23, 2024

I no longer see a memory leak and feel like a crazy person. I guess the scouting job is what measures the required memory? I'm back at square one.

from factorytools.

lawrenceleejr avatar lawrenceleejr commented on July 23, 2024

Ok I can see that if I comment out all of the algorithms except BasicEventSelection, there's no memory growth. The memory leak starts with CalibrateST.

In the execute call of CalibrateST, I've narrowed it down to the Get* calls to ST:

https://github.com/rsmith54/FactoryTools/blob/master/Root/CalibrateST.cxx#L207

Once L207-246 are uncommented, the leaking starts...

Maybe this is something we need to bring up with Martin+Zach?

Investigating.

-L

from factorytools.

lawrenceleejr avatar lawrenceleejr commented on July 23, 2024

Haha! Appears to be taus. Damn taus...

I'm going to comment out the GetTau call in CalibrateST and test on the grid.

from factorytools.

lawrenceleejr avatar lawrenceleejr commented on July 23, 2024

this appears to be entirely from the GetTaus() call in the CalibrateST alg.

Commenting out this line appears to remove the memory leak.

Memory usage on lxplus node after 10k events
Only BasicEventSelection+CalibrateST (w GetTaus() call) - 4.7%
Only BES+ST (no taus) - 3.1%

Entire job (no taus) - 3.1% 

Without the leak, should be able to run stably within 1 GB of RAM.

from factorytools.

lawrenceleejr avatar lawrenceleejr commented on July 23, 2024

Fixed in #124

from factorytools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.