Comments (10)
This is something I also thought about. It would be a non-trivial feature, so I am afraid this is more in the 1.0-territory.
So I absolutely agree with you. It's just that I always criticise it when other projects set the wrong priorities during the very early phases of their development and I don't want to be hypocrite.
Let's keep this issue open to remind me to put it on the roadmap! π
from credo.
Yeah, you're totally right, so maybe add a label longterm
or something similar.
from credo.
@maxnordlund Credo v0.3.0
now includes support for a @lint
attribute. These allow you to ignore indiviual checks on a perfunction basis. See CHANGELOG for further details.
What do you think?
from credo.
I love it πΈ
This combined with a good commit message should suffice to close this. But I would like a flag to temporarily ignore the @lint
attribute. Something one can run periodically to see if the ignores are still valid.
Close this if you like, unless you have a plan for this somehow π
from credo.
I like this idea of linting the @lint
attributes, which could result in a message like
"XYCheck ignored via @lint, but XY does not report any issues here."
Great idea! π
from credo.
Yes, yes! Lint all the things. If it will work like that it could probably be on all the time instead of hidden behind a flag. Which would mean your linting ignores will never be grow stale.
Den 10 feb. 2016 12:56 skrev "RenΓ© FΓΆhring" [email protected]:
I like this idea of linting the @lint attributes, which could result in a
message like"XYCheck ignored via @lint https://github.com/lint, but XY does not
report any issues here."Great idea! [image: π]
β
Reply to this email directly or view it on GitHub
#5 (comment).
from credo.
Yeah, that's what I was thinking: a @lint
checker that's just a regular check ... π±
from credo.
Yes, this is nice when you finally refactor some bit of code that needed ignored for a while and get to remove the @lint. It's also nice for "lint as you type" editor integration.
from credo.
@rrrene This was created prior to the credo:disable
feature, and I believe that is sufficient to close this issue?
from credo.
Yeah, I think so too.
from credo.
Related Issues (20)
- Predicate callbacks from behavior are not ignored HOT 2
- Issue with Unused variables confused about the strategy HOT 1
- missing spec on unquoted function raise error HOT 3
- Credo.Check.Warning.WrongTestFileExtension displayed in non-test module in v1.7.4 HOT 8
- NoAmbiguousAliases fails on function param with name alias HOT 3
- "Most of the time you are using the multi-alias/require/import/use syntax..." with compile_env HOT 4
- Gracefully handle output of bitstring `:message` in `%Credo.Issue{}` HOT 8
- False positive: spec in quoted HOT 3
- False Positive: Macro sigils with uppercase words HOT 4
- `UnusedKeywordOperation` check should ignore `Keyword.validate!/2` HOT 4
- Arguable advice from `Credo.Check.Refactor.AppendSingleItem` HOT 1
- Predicate function names should not start with 'is', and should end in a question mark flagged for :ets.whereis HOT 2
- Not ready for Elixir 1.16: a lot of 'warning: negative steps are not supported in Enum.slice/2 HOT 1
- Elixir 1.17 issues HOT 7
- Dependency divergence on compile HOT 2
- Unicode characters (arrows) that indicate priority of found issues not printed correctly HOT 2
- Credo.Check.Warning.Dbg: doesn't warn when using `&dbg/1`
- Error `mix credo` on Elixir 1.17 and Erlang/OTP 27 HOT 4
- Credo.Check.Design.SkipTestWithoutComment and many others, fail to run (Elixir 1.17 issue?) HOT 1
- Error upgrading project to Elixir 1.17 HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from credo.