Coder Social home page Coder Social logo

Persistent handling of issues about credo HOT 10 CLOSED

rrrene avatar rrrene commented on August 29, 2024
Persistent handling of issues

from credo.

Comments (10)

rrrene avatar rrrene commented on August 29, 2024

This is something I also thought about. It would be a non-trivial feature, so I am afraid this is more in the 1.0-territory.

So I absolutely agree with you. It's just that I always criticise it when other projects set the wrong priorities during the very early phases of their development and I don't want to be hypocrite.

Let's keep this issue open to remind me to put it on the roadmap! πŸ‘

from credo.

maxnordlund avatar maxnordlund commented on August 29, 2024

Yeah, you're totally right, so maybe add a label longterm or something similar.

from credo.

rrrene avatar rrrene commented on August 29, 2024

@maxnordlund Credo v0.3.0 now includes support for a @lint attribute. These allow you to ignore indiviual checks on a perfunction basis. See CHANGELOG for further details.

What do you think?

from credo.

maxnordlund avatar maxnordlund commented on August 29, 2024

I love it 😸
This combined with a good commit message should suffice to close this. But I would like a flag to temporarily ignore the @lint attribute. Something one can run periodically to see if the ignores are still valid.

Close this if you like, unless you have a plan for this somehow πŸ˜‰

from credo.

rrrene avatar rrrene commented on August 29, 2024

I like this idea of linting the @lint attributes, which could result in a message like

"XYCheck ignored via @lint, but XY does not report any issues here."

Great idea! πŸ‘

from credo.

maxnordlund avatar maxnordlund commented on August 29, 2024

Yes, yes! Lint all the things. If it will work like that it could probably be on all the time instead of hidden behind a flag. Which would mean your linting ignores will never be grow stale.

Den 10 feb. 2016 12:56 skrev "RenΓ© FΓΆhring" [email protected]:

I like this idea of linting the @lint attributes, which could result in a
message like

"XYCheck ignored via @lint https://github.com/lint, but XY does not
report any issues here."

Great idea! [image: πŸ‘]

β€”
Reply to this email directly or view it on GitHub
#5 (comment).

from credo.

rrrene avatar rrrene commented on August 29, 2024

Yeah, that's what I was thinking: a @lint checker that's just a regular check ... 😱

from credo.

chrismcg avatar chrismcg commented on August 29, 2024

Yes, this is nice when you finally refactor some bit of code that needed ignored for a while and get to remove the @lint. It's also nice for "lint as you type" editor integration.

from credo.

TheFirstAvenger avatar TheFirstAvenger commented on August 29, 2024

@rrrene This was created prior to the credo:disable feature, and I believe that is sufficient to close this issue?

from credo.

maxnordlund avatar maxnordlund commented on August 29, 2024

Yeah, I think so too.

from credo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.