Credo.Check.Warning.WrongTestFileExtension displayed in non-test module in v1.7.4 about credo

[rrrene]

@jderr-mx
Again, thanks for reporting this. What a stupid regression 😞 It should now be fixed on master.

You can try this by setting the Credo dep to

{:credo, github: "rrrene/credo"}

Please report back if your issue is solved! 👍

[rrrene]

I can reproduce this. Thx for reporting! 👍

[jderr-mx]

Hi @rrrene, I verified this fix is working in master

Thank you 🎉

[scohen]

@rrrene this does seem to fix the issue, but the fix seems to have drastically slowed down credo's checks. What used to take 6 or 7 milliseconds now takes more than 50 (at which point lexical stops the plugin from running).

Can I take a stab at improving the performance before you make a release? Releasing main right now will break lexical's credo plugin for whomever uses it (and people won't have credo warnings in their editors any more).

[scohen]

@rrrene you can ignore my comment, the slowdown was only for the first run (likely due to the Regex.compile), subsequent runs are back to the single digit milliseconds, which is plenty fast for lexical.

Can we get a release soon?

[RobertoSchneiders]

Thanks for fixing this, I'm waiting for the release as well.

[rrrene]

@jderr-mx @scohen @RobertoSchneiders This is live in v1.7.5.

[scohen]

Thanks, @rrrene! We love credo.