Comments (7)
from credo.
Fix included in v0.3.4
! Can you confirm this works as expected?
from credo.
@rrrene it works!
from credo.
Hi @rrrene I'm actually still getting this in 0.3.11. Two different cases:
┃ There are spaces around operators most of the time, but not here.
┃ lib/kafka_ex/compression.ex:55:47 (KafkaEx.Compression.snappy_decompress_chunk)
┃
┃ __ CODE IN QUESTION
┃
┃ def snappy_decompress_chunk(<< valsize :: 32-unsigned,
┃ ^
and
┃ There are spaces around operators most of the time, but not here.
┃ lib/kafka_ex/compression.ex:56:53 (KafkaEx.Compression.snappy_decompress_chunk)
┃
┃ __ CODE IN QUESTION
┃
┃ value :: size(valsize)-binary,
┃ ^
from credo.
@dantswain thanks for the report. will provide a fix.
from credo.
@dantswain I released a fix in v0.3.12
P.S. You should be awarded some internet points for re-opening an existing, relevant issue instead of creating a new one. Well done!
from credo.
Confirmed it fixed the issues I was seeing. Thanks!
from credo.
Related Issues (20)
- False positive on NestedFunctionCalls check HOT 2
- False positive on MultiAliasImportRequireUse when using multiple modules in same file HOT 1
- False positive of `Credo.Check.Warning.UnusedStringOperation` HOT 3
- False positive: Identical sub-expression of || and && operator HOT 4
- False positive: snake_case warning for operators HOT 6
- MissedMetadataKeyInLoggerConfig shouldn't warn if you don't use the console logger backend HOT 6
- mix credo diff --from-git-ref master showing issues in files not modified HOT 5
- False negative: Nested blocks inside an if/else clause are not detected HOT 4
- Parse error with escaped heredocs HOT 2
- coworker wrote this, you may want to add it to credo HOT 3
- MissedMetadataKeyInLoggerConfig breaks with `metadata: :all` HOT 1
- Readability.NestedFunctionCalls triggered on function calls in interpolated strings
- Ignore ansi_color metadata key HOT 2
- Sarif output cannot be parsed by `github/codeql-action/upload-sarif@v2` HOT 4
- False positive: Use a pipeline when there are nested function calls HOT 2
- Compilation error in file lib/credo/check/consistency/exception_names.ex HOT 1
- `Credo.Check.Warning.MissedMetadataKeyInLoggerConfig` should by default allow Erlang's metadata keys HOT 5
- Include both start and end line_no and column in issue HOT 6
- show allow TODO Tag
- Adding `uniq` to dependencies breaks null-ls in neovim HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from credo.