roycyang / sencha-touch-extensions Goto Github PK

Your contribution is valuable to the open source community. It would be great if you could add a license . It would definitely help everyone. Thank you again.

The template config is currently set to:

    template: [
        {
            tag: 'span',
            reference: 'tapMask',
            style: {
                position: 'absolute',
                width: '100%',
                height: '100%',
                boxSizing: 'content-box'
            }
        },
        {
            tag: 'span',
            reference: 'badgeElement',
            hidden: true
        },
        {
            tag: 'span',
            className: Ext.baseCSSPrefix + 'button-icon',
            reference: 'iconElement',
            hidden: true
        },
        {
            tag: 'span',
            reference: 'textElement',
            hidden: true
        }
    ]

You'll notice that the icon element is set to hidden. I looked at Sencha Touch 2.1 and see that's what the stock button does. So I presume FixedButton just does the same thing, and perhaps the button class shows it if an iconCls is set.

But in Sencha Touch 2.4, the stock button does not set the template config for icon element to hidden. Perhaps the code starts with the assumption it's visible and only hides it if necessary. Therefore, for FixedButton to work with 2.4, it also needs to remove that hidden value. Otherwise, the icon will not display if set.