roxieceleste / sciencecontainers Goto Github PK

Only other mod is MM.

[ERR 19:12:58.377] AssemblyLoader: Exception loading 'ScienceContainers': System.Reflection.ReflectionTypeLoadException: The classes in the module cannot be loaded.
at (wrapper managed-to-native) System.Reflection.Assembly:GetTypes (bool)
at System.Reflection.Assembly.GetTypes () [0x00000] in :0
at AssemblyLoader.LoadAssemblies () [0x00000] in :0

Additional information about this exception:

System.TypeLoadException: Could not load type 'ScienceContainers.CapsuleScienceContainer' from assembly 'ScienceContainers, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null'.

System.TypeLoadException: Could not load type 'ScienceContainers.ProbeScienceContainer' from assembly 'ScienceContainers, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null'.

System.TypeLoadException: Could not load type 'd__6' from assembly 'ScienceContainers, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null'.

System.TypeLoadException: Could not load type '<>c__DisplayClassa' from assembly 'ScienceContainers, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null'.

System.TypeLoadException: Could not load type 'd__a' from assembly 'ScienceContainers, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null'.

System.TypeLoadException: Could not load type '<>c__DisplayClasse' from assembly 'ScienceContainers, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null'.

noticed a low occurrence condition with the MM patch you have right now, if a mod has a ModuleScienceLab part with module command you get a part with 2 CapsuleScienceContainer modules. (since MM applies all the patches in a pass at once)
Reworked the Patch slightly to prevent this.

Note: If you need to be after a specific patch, AFTER[pass name] is used in current MM configs as long as the other guy is playing nice and naming his patches. If he isn't you will be after him anyway since he will run in the main FIRST pass, and if he uses FINAL it wouldn't help anyway since they all run at once.

• I've moved the pass from FINAL to FOR[ScienceContainers] this will run after the main patch pass, in alphabetical order with the reset of the named passes. allowing the users to have FINAL for themselves.
• added the corresponding ! container check to each patch. you never know what may have been mistakenly added by someone else. (users can still screw this up, but it's better than nothing)
• added !MODULE[ModuleCommand] to the ModuleScienceLab patch to prevent duplicate modules.

// Add CapsuleScienceContainer to Command Parts with Stock Science Containers
@PART[*]:HAS[@MODULE[ModuleCommand],@MODULE[ModuleScienceContainer],!MODULE[ProbeScienceCollector],!MODULE[CapsuleScienceCollector]]:FOR[ScienceContainers]
{    
    MODULE
    {
        name = CapsuleScienceContainer
    }
}
// Add ProbeScienceContainer to Command Parts without Stock Science Containers
@PART[*]:HAS[@MODULE[ModuleCommand],!MODULE[ModuleScienceContainer],!MODULE[ProbeScienceCollector],!MODULE[CapsuleScienceCollector]]:FOR[ScienceContainers]
{    
    MODULE
    {
        name = ProbeScienceContainer
    }
}
// Add CapsuleScienceContainer to ModuleScienceLab parts with Stock Science Containers and No Command Module
@PART[*]:HAS[@MODULE[ModuleScienceLab],@MODULE[ModuleScienceContainer],!MODULE[ModuleCommand],!MODULE[ProbeScienceCollector],!MODULE[CapsuleScienceCollector]]:FOR[ScienceContainers]
{    
    MODULE
    {
        name = CapsuleScienceContainer
    }
}

Hope this has been helpful 😃

(ran into the duplicate problem with the roverdude's MKS/OKS Science Labs, since it has modulesciencelab and all the MKS modules have module command as well)