Coder Social home page Coder Social logo

fisa's Introduction

fisa's People

Contributors

rosssmyth avatar

Watchers

 avatar  avatar  avatar

fisa's Issues

Error checking for double colons

The VISA standard indicates that double colons are required in addresses. Because of this the USB parser just skips over the character following the first colon assuming that it is a second. It would be good practice to instead provide an error.
Tasks:

  • Check for second colon
    Should this be a guard or in the match body? Doesn't really matter to me I think. Guard may be cleaner.
  • Add "MissingColon" error to error enum
  • Return the error
  • Add UI tests

Determine MSRV

This is pretty low priority and I personally don't care what it is. But I would like to know what it is so other people can know.

Async?

Is async worth implementing? My thought is probably yes. At least feature gated. I'll have to do a survey of async USB and serial libraries as I know TCP libraries exist. For runtime Tokio is probably the way. If not then maybe smol?

Address builder

Should probably make a builder API for making addresses programmatically.

Is it valid for a serial number to have a colon?

Currently the USB parser considers a serial number to be done when either:

  1. The str ends
  2. A single colon is met

If a serial number can have a single colon then this is invalid.

Other thoughts:

  • Theoretically the serial number could have two colons as long as the immediate characters after the colons are not numbers. But this sounds too complex for me to think about.

Book

Writing books is good. For 1.0 writing a book on how to use this library and also a bit about VISA would be good.

Licensing?

I'm a bit unsure on what license I want to use. But I think MPL is a good one.

IO

Once parsers are done the actual IO must be setup. I'll have to give this more thought, but making some traits for interfacing with the IO types is probably the way to go.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.