rosme / rsm Goto Github PK

Config currently does not support the move semantics.

The goal is to have a class that you can pass the argc and argv to be parsed, and you can query if certain arguments are present.

You can also specify the scheme you want and that if an argument is supposed to have a parameter and it's missing, the parsing will fail.

e.g. -myArgument . If is missing, the parsing returns false and you can show an error to the end user.

It could be interesting to add the time to the logging for better tracking.

Replace where possible all typedef to using. Thus code like
typedef std::string Key;
will become
using Key = std::string;

This is the proper usage in C++11 and it doesn't change the way to use those types.

Multiple class could benefit from a static_assert (e.g. matrix constructor for verifying >0)

Currently, the code require to pass something to the logging function:
rsm::Logger::debug("ToLog")

This prevent chaining easily. It could be interesting to offer a stream somehow so this could be done:
rsm::Logger::debug() << "ToLog" << "Other Data"

It will throw in code. Needs a different solution for OS X. Possibly a refactoring.

Have the logger allow for a maximum level to be shown. (e.g. Debug for debug builds, but Warning for Release builds).

The lowest the level set, the more it shows:

Debug -> everything (Debug, Info, Warning, Critical, Error)
Info -> Info, Warning, Critical, Error
Warning -> Warning, Critical, Error
Critical -> Critical, Error
Error -> Error

In the C++11 mindset, all classes that shouldn't be inherited should have the final specifier.

Currently, the logging just output, but there is no time information.

It would be nice to have this information, something like this:

[7h54m12s][Debug]: This is a debug line

m_running is not atomic but is use between thread. Should be std::atomic.

The default logger is still synced with io. Should make sure to deactivate that.

default path examples:

• Font path
• Resources path (macOS)
• Log path (linux, macOS)