Coder Social home page Coder Social logo

Comments (8)

dirk-thomas avatar dirk-thomas commented on July 24, 2024 1

Each package already has the version number declared in the package.xml file which also gets bumped for every release. That value is available in CMake as <pkgname>_VERSION after the manifest file was parsed (that happens either in ament_package() or when ament_package_xml() is called any time earlier). So that information could be used for the macros which will need to be generated using configure_file().

from rcutils.

dirk-thomas avatar dirk-thomas commented on July 24, 2024

That sounds like a good idea. Please consider to contribute pull requests for packages where you see the need for it.

from rcutils.

serge-nikulin avatar serge-nikulin commented on July 24, 2024

@dirk-thomas,

I can do a naive versioninig: plain C/C++ macros that should be upgraded manually before each build.

A "grownup", a right way to do versioning is to keep the last built version in some external DB and increment the minor version automatically and major/minor versions in a semi-auto way (via Jenkins commands?). This approach IMO should be implemented by ROS2 insiders who have full access to build infrastructure.

@dirk-thomas, should I go ahead with the naive approach pull request?

from rcutils.

serge-nikulin avatar serge-nikulin commented on July 24, 2024

@dirk-thomas, see #175

from rcutils.

aprotyas avatar aprotyas commented on July 24, 2024

@clalancette how broad is this issue? rclcpp already generates a version header. Is there also a need for that in rcutils?

from rcutils.

clalancette avatar clalancette commented on July 24, 2024

@clalancette how broad is this issue? rclcpp already generates a version header. Is there also a need for that in rcutils?

I have no idea, honestly. Maybe @serge-nikulin can weigh in.

from rcutils.

serge-nikulin avatar serge-nikulin commented on July 24, 2024

@aprotyas

@clalancette how broad is this issue? rclcpp already generates a version header. Is there also a need for that in rcutils?

This issue is very old. Back in 2019 ROS2 did not have any version information.
You can close this issue I guess.

Back then I wanted to generate version information for every generated library.
Rationale: in many shops, all files must have version information, and many safety and security standards require version tagging of every distributed file.

from rcutils.

clalancette avatar clalancette commented on July 24, 2024

Based on the previous comment, closing. Feel free to reopen if you change your mind and would like to continue.

from rcutils.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.